Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Albert Astals Cid
El Dilluns, 11 de novembre de 2013, a les 19:36:45, Kevin Krammer va escriure: > On Monday, 2013-11-11, 19:17:22, Albert Astals Cid wrote: > > El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va > > > > > I've wasted my fair share of time on this in Trojita where we disconnect > >

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Jan Kundrát
On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: Not sure you're understanding what i say, we have an explicit check about QDialog on stack+exec that says "it will crash if you dbus quit". We've chatted about this with Albert on IRC. My understanding of this is that there ar

Re: kde-workspace git broken ?

2013-11-11 Thread Ben Cooksley
Hi everyone, I have now force pushed kde-workspace to return it to a valid state. + 09ea308...008ac5e 008ac5efabfb99f04813e5dad29c2d0a92d13fc5 -> master (forced update) + 8105121...f1b57a9 f1b57a9ca9193fb94d985b5cc6d739866c5c59d2 -> KDE/4.11 (forced update) I have also blacklisted the following

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Thomas Lübking
On Montag, 11. November 2013 19:17:22 CEST, Albert Astals Cid wrote: Not sure you're understanding what i say, we have an explicit check about QDialog on stack+exec that says "it will crash if you dbus quit". What I'm saying is that this doesn't happen anymore and we should remove that check.

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Kevin Krammer
On Monday, 2013-11-11, 19:17:22, Albert Astals Cid wrote: > El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va > > I've wasted my fair share of time on this in Trojita where we disconnect > > from the IMAP server upon seeing a network error. This, naturally, leads > > to > > free

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Albert Astals Cid
El Diumenge, 10 de novembre de 2013, a les 15:45:42, Jan Kundrát va escriure: > On Saturday, 9 November 2013 23:45:20 CEST, Albert Astals Cid wrote: > > But I don't think that's a problem anymore. I tried to crash it > > by doing what > > the blog says and it doesn't crash, and after having a look

Re: Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-11 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113714/ --- (Updated Nov. 11, 2013, 5:15 p.m.) Status -- This change has been mar

Re: Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113714/#review43444 --- This review has been submitted with commit a01e4ee686f369e4e7d

Re: kde-workspace git broken ?

2013-11-11 Thread Hugo Pereira Da Costa
On 11/11/2013 02:13 PM, Martin Gräßlin wrote: On Monday 11 November 2013 13:29:32 Hugo Pereira Da Costa wrote: Hello, I think commits 9f70241d57f3ba1013b9f28650478c8bbb1233e0 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b 09ea308ab55505efe7aeaebcd4aef6292cd884e6 seriously broke kde-workspace yes, it

Re: kde-workspace git broken ?

2013-11-11 Thread Sven Brauch
On Monday 11 November 2013 14:13:22 Martin Gräßlin wrote: > Please remember: do not push a revert of a merge commit. Another tip not everyone might know: you can use git push --dry-run to see which changes would be pushed, without actually pushing them. That helps a lot with avoiding breakage.

Re: kde-workspace git broken ?

2013-11-11 Thread Martin Gräßlin
On Monday 11 November 2013 13:29:32 Hugo Pereira Da Costa wrote: > Hello, > I think commits > 9f70241d57f3ba1013b9f28650478c8bbb1233e0 > 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b > 09ea308ab55505efe7aeaebcd4aef6292cd884e6 > > seriously broke kde-workspace yes, it's broken. I already created a sysad

kde-workspace git broken ?

2013-11-11 Thread Hugo Pereira Da Costa
Hello, I think commits 9f70241d57f3ba1013b9f28650478c8bbb1233e0 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b 09ea308ab55505efe7aeaebcd4aef6292cd884e6 seriously broke kde-workspace At least several changes in oxygen where reverted in the process. (below is a diff of oxygenstyle.h between 008ac5efabfb

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-11 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/ --- (Updated Nov. 11, 2013, 11:31 a.m.) Status -- This change has been ma

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43419 --- This review has been submitted with commit 9f70241d57f3ba1013b