Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43284 --- Ship it! Because of the icoutils requirement on non windows sy

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Ralf Habacker
> On Nov. 8, 2013, 5:31 p.m., Andrius da Costa Ribas wrote: > > ping? may I ship it? I can confirm that this patch works on linux opensuse 12.2 with kde 4.11. Exe and windows thumbnail are visible in dolphin with installed icoutils package and enabled preview. - Ralf --

Re: Adopting AppData in KDE?

2013-11-08 Thread T.C. Hollingsworth
On Wed, Nov 6, 2013 at 1:40 AM, Richard Hughes wrote: > I'm not sure how well this will work, at least in gnome-software we > allow the user to match on a keyword cache using the "C" name, and > also the UTF8 and normalized versions of their current locale. Nah, I meant for the extractor tools to

Re: Adopting AppData in KDE?

2013-11-08 Thread T.C. Hollingsworth
On Tue, Nov 5, 2013 at 1:53 PM, Matthias Klumpp wrote: > Hi! > In order to solve the translation-issues: I think KDE could very well > use Scripty to insert translations into the AppData files. I wrote a draft patch to do this already: http://lists.kde.org/?l=kde-i18n-doc&m=138353976230003&w=2 T

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Tue, Nov 5, 2013 at 9:49 PM, Matthias Klumpp wrote: > 2013/11/5 Todd : > > [...] > > Looking at the spec, I have a few suggestions: > (I assume you mean the AppStream spec) > > For , I think it would be good to allow arbitrary groups > > rather than limiting it to only a few recognized groups.

Re: Can we make api.kde.org search better?

2013-11-08 Thread Michael Reeves
On Nov 5, 2013 6:44 PM, "Albert Astals Cid" wrote: > > > Well Michael Reeves volunteered, no? Allen are you sending him the data? > > Cheers, > Albert > > > > > Aleix > I got the data.

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Nov 5, 2013 6:42 PM, "Richard Hughes" wrote: > > On 5 November 2013 17:37, Todd wrote: > >> Define ChangeLog? You mean what changed between versions? > > Yes, as well as the version number and date, probably. > > I'd be open to ideas about this. Can you file an issue and we can talk > about po

Re: Adopting AppData in KDE?

2013-11-08 Thread Todd
On Tue, Nov 5, 2013 at 6:21 PM, Richard Hughes wrote: > On 5 November 2013 17:12, Todd wrote: > > For , I think it would be good to allow arbitrary groups > > rather than limiting it to only a few recognized groups. > > I think restricting it to the desktops specified in the menu-spec makes > se

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43272 --- ping? may I ship it? - Andrius da Costa Ribas On Aug. 17, 20

Re: Can we make api.kde.org search better?

2013-11-08 Thread Allen Winter
On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: > Hi, yesterday i was talking with someone about the desktop file class we have > in KDE, he tried to find its api by going to > api.kde.org > and typing > desktop > in the Search bar. > > If you do that > http://api.kde.o

Re: Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113714/#review43251 --- Ship it! The analysis and patch seem correct. I was initially