Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-25 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Oct. 26, 2013, 4:57 a.m.) Review request for kde-workspace. Cha

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42378 --- How does it look on 1024 pixel wide screens (not that I want to

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42377 --- Could you also post a preview for French ? It should have 4 sym

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 25, 2013, 7:13 p.m.) Review request for KDE Runtime, kde-wor

Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-25 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/ --- (Updated Oct. 25, 2013, 6:26 p.m.) Status -- This change has been mar

Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/#review42370 --- This review has been submitted with commit c5db302e5305f668489

Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/#review42355 --- Ship it! Ship It! - Dawit Alemayehu On Oct. 21, 2013, 1:41

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-25 Thread Dawit Alemayehu
> On Oct. 22, 2013, 8:08 a.m., David Faure wrote: > > kioslave/smb/kio_smb_dir.cpp, line 285 > > > > > > I'm pretty sure this cast is wrong. QFile::Permissions doesn't map to > > mode_t, at least not with a simpl

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 25, 2013, 1:10 p.m.) Review request for KDE Runtime. Bugs:

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42345 --- I think a screenshot would nicely go along with this ;) (Updat

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-25 Thread Jan Kundrát
> On Oct. 25, 2013, 7:02 a.m., Jan Kundrát wrote: > > > (d) Use QVector::reserve to reserve the appropriate size for the > > > QVector. Saves some time when loading the UDSEntry, and reduces > > > the memory usage further. > > > > It isn't clear to me how a call to QVector::reserve might reduc

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-25 Thread Frank Reininghaus
> On Oct. 25, 2013, 7:02 a.m., Jan Kundrát wrote: > > > (d) Use QVector::reserve to reserve the appropriate size for the > > > QVector. Saves some time when loading the UDSEntry, and reduces > > > the memory usage further. > > > > It isn't clear to me how a call to QVector::reserve might reduc

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-25 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42330 --- > (d) Use QVector::reserve to reserve the appropriate size for