Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-24 Thread Andrea Iacovitti
> On Oct. 25, 2013, 2:55 a.m., Dawit Alemayehu wrote: > > I have no objection to this patch. However, I want to make sure you have > > tested the other modes before I give it a thumbs up. Did you try the manual > > proxy setup with your patch? Also adding some exceptions to make sure it > > ho

Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/#review42328 --- I have no objection to this patch. However, I want to make sure

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-24 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42327 --- Just some minor nitpicking that i can see. kio/kio/udsentry.c

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-24 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/ --- (Updated Oct. 24, 2013, 10:34 p.m.) Review request for kdelibs. Changes

Review Request 113413: Improved Keyboard Layout Preview

2013-10-24 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- Review request for KDE Runtime, kde-workspace and Andriy Rysin. Repository

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Thomas Lübking
> On Oct. 24, 2013, 3:35 p.m., Ivan Čukić wrote: > > Actually, this is something that I wanted to do ever since I saw it on a > > different screen to the one I had when I made it. > > > > If you want to try it with a radial gradient, mind that around the logo, > > the background needs to be pi

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Fredrik Höglund
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Sebastian Kügler
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Thomas Lübking
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Gräßlin
> On Oct. 24, 2013, 6:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42299 --- What's the cold startup time like for KSplashQML compared to KS

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Ivan Čukić
> On Oct. 24, 2013, 3:35 p.m., Ivan Čukić wrote: > > Actually, this is something that I wanted to do ever since I saw it on a > > different screen to the one I had when I made it. > > > > If you want to try it with a radial gradient, mind that around the logo, > > the background needs to be pi

Re: Review Request 113147: Propagate NTP clock to hwclock, too

2013-10-24 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113147/ --- (Updated Oct. 24, 2013, 3:38 p.m.) Status -- This change has been mar

Re: Review Request 113147: Propagate NTP clock to hwclock, too

2013-10-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113147/#review42293 --- This review has been submitted with commit bf9b5b66771e78a0e12

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/#review42292 --- Actually, this is something that I wanted to do ever since I sa

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Albert Astals Cid
> On Oct. 24, 2013, 3:08 p.m., Mark Gaiser wrote: > > -1 > > > > I have to add some explanation to that. > > > > I'm all OK with plain and simplistic, but not TOO plain and simplistic > > (aka, the Windows 8 and apple route). We don't live in a monochrome age > > anymore so i think the theme

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/ --- (Updated Oct. 24, 2013, 3:15 p.m.) Review request for kde-workspace and Pl

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
> On Oct. 24, 2013, 3:08 p.m., Mark Gaiser wrote: > > -1 > > > > I have to add some explanation to that. > > > > I'm all OK with plain and simplistic, but not TOO plain and simplistic > > (aka, the Windows 8 and apple route). We don't live in a monochrome age > > anymore so i think the theme

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/#review42286 --- -1 I have to add some explanation to that. I'm all OK with pl

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/#review42284 --- IMHO ship it! but I will wait for others to give you "Ship It!"

Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/ --- Review request for kde-workspace and Plasma. Repository: kde-workspace D

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/ --- (Updated Oct. 24, 2013, 2:19 p.m.) Status -- This change has been mar

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42283 --- This review has been submitted with commit 90e2c0b65cce3f899d4

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42281 --- Ship it! Looks ok. It will need testing with the startkde/star

Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/ --- Review request for kde-workspace and KDE Frameworks. Repository: kde-works

please delete kde-workspace master-xcb remote branch

2013-10-24 Thread Hugo Pereira Da Costa
Hi, could someone with proper credentials delete the kde-workspace remote branch called master-xcb, I just created it *by mistake* while pushing some changes to master ? Thanks in advance, Hugo