---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113342/
---
Review request for kdelibs and David Faure.
Repository: kdelibs
Descript
Git commit 804d35394c3667ae4e9fe20321b6365cd8467e7d by Stephen Kelly.
Committed on 18/10/2013 at 15:33.
Pushed by skelly into branch 'KDE/4.11'.
Only create and install man pages if using CMake < 3.0
CMake documentation changes in CMake 3.0.0 such that running
cmake --help-custom-modules no longe
On Monday 08 of July 2013 19:19:08 David Edmundson wrote:
> Code wise, things looks pretty good.
>
> Minor comments:
> - the library is GPL, not LGPL which is the norm for libraries.
> Is this deliberate?
No, I don't think so. I'm just fine with changing it to LGPL (and I guess Alex
will be too
On Friday 18 October 2013 01:51:06 Albert Astals Cid wrote:
> El Dijous, 17 d'octubre de 2013, a les 14:37:43, David Edmundson va
escriure:
> > This has been in kdereview for over 3 months now. It is probably safe
> > to move, though I would still like a reply to my comments
> >
> > We should not
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113260/
---
(Updated Oct. 18, 2013, 1 p.m.)
Review request for KDE Runtime, KDE Framew
On Monday 14 October 2013 23:52:49 Albert Astals Cid wrote:
> Hi guys, seems that KService has regressed and now it does not include all
> the mimetypes listed in the .desktop file anymore.
Fixed in
http://commits.kde.org/kdelibs/f723e2e7d36b597c5262bf63dde380d89ec6bfcb
--
David Faure, fa...@kde
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112258/
---
(Updated Oct. 18, 2013, 7:41 a.m.)
Review request for kde-workspace and Jo
