KService has regressed

2013-10-14 Thread Albert Astals Cid
Hi guys, seems that KService has regressed and now it does not include all the mimetypes listed in the .desktop file anymore. Code to fix BUG 321706 seems to have added a check for // Only add unique mimetypes When that is not the behavior that kservice used to had, and it's not the document

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113218/#review41758 --- This review has been submitted with commit 61c81131867af964496

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-14 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113218/ --- (Updated Oct. 14, 2013, 9:28 p.m.) Status -- This change has been mar

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/ --- (Updated Oct. 14, 2013, 1:40 p.m.) Status -- This change has been dis

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/ --- (Updated Oct. 14, 2013, 6:40 p.m.) Status -- This change has been mar

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/#review41755 --- This review has been submitted with commit aa3982d83ab56421f30

Re: Review Request 113242: Make UdevProcessor work with modern udev

2013-10-14 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113242/#review41748 --- Ship it! confirmed working with older udev >>> solid-hardware

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/ --- (Updated Oct. 14, 2013, 4:16 p.m.) Status -- This change has been mar

Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- (Updated Oct. 14, 2013, 4:16 p.m.) Status -- This change has been mar

Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/#review41742 --- This review has been submitted with commit fa58b5a00540b4697bc

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41741 --- This review has been submitted with commit af8deabf64506b4f3ee

Review Request 113242: Make UdevProcessor work with modern udev

2013-10-14 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113242/ --- Review request for kdelibs, Rohan Garg and Harald Sitter. Repository: kdel

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-14 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41727 --- There is nobody to review this simple complation fix for OSX ?

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113218/#review41725 --- Ship it! >From the KF5 side, this shouldn't be a problem. - A

Re: Review Request 113194: port away from KIcon in libs/taskmanager

2013-10-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113194/ --- (Updated Oct. 14, 2013, 1:11 p.m.) Status -- This change has been mar

Re: Review Request 113194: port away from KIcon in libs/taskmanager

2013-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113194/#review41716 --- This review has been submitted with commit ec331326e4a8d6cb96d

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
> On Oct. 14, 2013, 12:52 p.m., David Faure wrote: > > tier1/kcoreaddons/src/lib/jobs/kjob.h, line 372 > > > > > > I wonder if the Qt/kdelibs coding style has something about indentation > > of pre-processor dire

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41714 --- Ship it! tier1/kcoreaddons/src/lib/jobs/kjob.h

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 14, 2013, 12:46 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
> On Oct. 14, 2013, 6:47 a.m., Kevin Ottens wrote: > > Why do it just for result and not finished, suspended, resumed? We end up > > with both mechanisms for private signals in the same header otherwise. Will do. Will update this patch shortly. - Mark ---

Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget

2013-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- (Updated Oct. 14, 2013, 10:25 a.m.) Review request for kdelibs and David F

Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget

2013-10-14 Thread Vishesh Handa
> On Oct. 11, 2013, 6:14 a.m., David Faure wrote: > > Which branch is this for? Master? Yes this is for master. We'll still be having a 4.12 release of kdelibs, right? - Vishesh --- This is an automatically generated e-mail. To reply, v

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41675 --- Yes, should have a note in KDE5Porting before going in. - Kevi

Re: Review Request 101348: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2013-10-14 Thread Kevin Ottens
> On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote: > > Is there any progress on this? > > I’d propose you enhance the feature to make the individual activities > > selectable, i.e. you can choose in which particular activities an entry > > should appear, similar to KWin’s "Activity" menu in

Cleanup of clone and scratch repositories

2013-10-14 Thread Ben Cooksley
Hi all, Just a short reminder to all to please cleanup any clone or scratch repositories you are no longer using on git.kde.org. This is particularly the case for staging repositories used for storing interim conversions to Git for SVN based projects (for others to review), which have since compl