Re: Packaging KDE Foundation 5 frameworks

2013-10-13 Thread Kevin Ottens
Hello, On Wednesday 09 October 2013 11:10:03 Lubomir Rintel wrote: > I'm wondering what's your position on naming the packages? Does kf5-* > prefix (kf5-solid, kf5-extra-cmake-modules) make sense to you? OpenSUSE > seems to use that (except that they don't include the prefix for ECM). > [1] It do

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-13 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41670 --- Why do it just for result and not finished, suspended, resumed?

Re: Review Request 113194: port away from KIcon in libs/taskmanager

2013-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113194/#review41669 --- Ship it! Looks good to me, it's what you should be doing accor

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/#review41662 --- Ship it! Ship It! - David Faure On Oct. 13, 2013, 6:07 p.m.

Re: Review Request 108312: Use view-certificate for SSL settings KCM

2013-10-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108312/ --- (Updated Oct. 13, 2013, 6:20 p.m.) Review request for kdelibs and KDE Usab

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/ --- (Updated Oct. 13, 2013, 6:07 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request 113216: some little performance improvement for network kio

2013-10-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/#review41651 --- Imo it's wrong to return const& in the first place. You can bin

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called "size_fdiag"

2013-10-13 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/ --- (Updated Oct. 13, 2013, 4:18 p.m.) Status -- This change has been mar

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called "size_fdiag"

2013-10-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/#review41647 --- This review has been submitted with commit fa0a5cfc5755b282b38