Re: Review Request 113161: replace deprecated KCalendarSystem::create

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113161/#review41470 --- This review has been submitted with commit 14ea70e8f87e63c7e5c

Re: Review Request 113161: replace deprecated KCalendarSystem::create

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113161/ --- (Updated Oct. 9, 2013, 11:02 p.m.) Status -- This change has been mar

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113162/ --- (Updated Oct. 9, 2013, 10:59 p.m.) Status -- This change has been mar

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113162/#review41469 --- This review has been submitted with commit b048956b91a908649e4

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

> On Oct. 9, 2013, 11:24 a.m., Jan Kundrát wrote: > > You can even make it a `const char * const` to communicate that the actual > > pointer itself is const, too. > > > > That said, in this particular case I would just use a hardcoded "HOME" in > > both getenv and setenv for simplicity, but I'

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153/#review41459 --- Ship it! Makes sense, as long as there's a replacement. :) May

Re: Packaging KDE Foundation 5 frameworks

On Wednesday 09 October 2013, Lubomir Rintel wrote: > Hi, > > I know it's a bit too early, but still better than late. I'd like to > know your thoughts about the way KF5 frameworks will be packaged for > Linux distributions. > > I'm currently working on including Hawaii desktop (based around a Qt

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

> On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote: > > I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any > > opinion? > > > > If we ignore that point for the moment, and think in terms of KF5, ATM it > > would go with KColorScheme in KConfigWidgets. I'm not quite sold on t

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112367: Include the icon's theme in the cache key

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

> On Oct. 9, 2013, 11:24 a.m., Jan Kundrát wrote: > > You can even make it a `const char * const` to communicate that the actual > > pointer itself is const, too. > > > > That said, in this particular case I would just use a hardcoded "HOME" in > > both getenv and setenv for simplicity, but I'

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

> On Oct. 9, 2013, 11:24 a.m., Jan Kundrát wrote: > > You can even make it a `const char * const` to communicate that the actual > > pointer itself is const, too. > > > > That said, in this particular case I would just use a hardcoded "HOME" in > > both getenv and setenv for simplicity, but I'

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

> On Oct. 9, 2013, 11:24 a.m., Jan Kundrát wrote: > > You can even make it a `const char * const` to communicate that the actual > > pointer itself is const, too. > > > > That said, in this particular case I would just use a hardcoded "HOME" in > > both getenv and setenv for simplicity, but I'

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113162/#review41425 --- You can even make it a `const char * const` to communicate that

Packaging KDE Foundation 5 frameworks

Hi, I know it's a bit too early, but still better than late. I'd like to know your thoughts about the way KF5 frameworks will be packaged for Linux distributions. I'm currently working on including Hawaii desktop (based around a Qt5 and Wayland-based compositor) in Fedora. We aim at delivering it

Re: Fwd: looking for phonon gstreamer maintainer

On Tuesday 08 October 2013 10:52:26 Harald Sitter wrote: > > libVLC and libVLCcore are not more patent-encumbered than > > gstreamer-core. > > > FWIW rdieter and j-b were able to clear up the confusion on IRC and > apparently there now are plans to get vlc-without-patent-plugins into > Fedora \o/