Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov
> On Sept. 29, 2013, 4:24 p.m., David Faure wrote: > > The name "token" surprises me a bit. Is this a usual naming scheme for > > accessing C++ classes from QML? > > Otherwise I would think the QML code would want to just write KColorScheme. > > > > Maybe the registration could be done in a sta

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sebastian Kügler
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Jonathan Marten
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/#review41400 --- I'm not totally happy with this change. Yes, the internal view

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ --- (Updated Oct. 8, 2013, 3:23 p.m.) Review request for KDE Base Apps. Chan

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ --- (Updated Oct. 8, 2013, 3:17 p.m.) Review request for KDE Base Apps. Repo

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/#review41398 --- You should remove the functions from the headerfile as well. -

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ --- (Updated Oct. 8, 2013, 3:13 p.m.) Review request for KDE Base Apps. Repo

Re: Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ --- (Updated Oct. 8, 2013, 3:11 p.m.) Review request for KDE Base Apps and Rap

KF5 Update Meeting Minutes 2013-w41

2013-10-08 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 41 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, jpwhiting, mck182, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * If you didn't read my email on stop the li

Review Request 113175: Always use an external viewer application to view files

2013-10-08 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ --- Review request for KDE Base Apps. Repository: ark Description --- T

Re: Fwd: looking for phonon gstreamer maintainer

2013-10-08 Thread Harald Sitter
On Mon, Oct 7, 2013 at 2:36 PM, Jean-Baptiste Kempf wrote: > On 04 Oct, Daniel Vrátil wrote : >> in Fedora we have a big interest in keeping phonon-gstreamer alive, namely >> because we can't ship phonon-vlc due to legal issues (you know, US company, >> software patents and what not...) and our us

Re: Fwd: looking for phonon gstreamer maintainer

2013-10-08 Thread Harald Sitter
On Fri, Oct 4, 2013 at 5:50 PM, Daniel Vrátil wrote: > On Wednesday 25 of September 2013 12:35:25 Harald Sitter wrote: >> -- Forwarded message -- >> From: Harald Sitter >> Date: Mon, Sep 23, 2013 at 4:55 PM >> Subject: looking for phonon gstreamer maintainer >> To: "For discussion

Re: Fwd: looking for phonon gstreamer maintainer

2013-10-08 Thread Jean-Baptiste Kempf
On 04 Oct, Daniel Vrátil wrote : > in Fedora we have a big interest in keeping phonon-gstreamer alive, namely > because we can't ship phonon-vlc due to legal issues (you know, US company, > software patents and what not...) and our users would not probably be very This is a bit untrue, tbh and