Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111093/ --- (Updated Sept. 24, 2013, 4:42 p.m.) Status -- This change has been ma

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111093/#review40711 --- This review has been submitted with commit 9ad726f709161853932

Re: Review Request 112756: KLinkItemSelectionModel: Do not change current index of mapped model if the mapped one is invalid

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112756/ --- (Updated Sept. 24, 2013, 3:42 p.m.) Status -- This change has been ma

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-24 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 24, 2013, 4:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 112756: KLinkItemSelectionModel: Do not change current index of mapped model if the mapped one is invalid

2013-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112756/#review40708 --- This review has been submitted with commit dfcf2ffb1a934cf7dc4

Re: Review Request 112575: KMenuedit documentation - improve introduction chapter and add use case section

2013-09-24 Thread Julien Borderie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112575/#review40706 --- Ship it! Ship It! - Julien Borderie On Sept. 21, 2013, 3:41

KF5 Update Meeting Minutes 2013-w39

2013-09-24 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 39 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, dfaure, mck182, mgraesslin, sebas, shadeslayer, teo, vHanda, wojtask9 and myself. Announcement: * I will be away next week, a

Re: Review Request 112756: KLinkItemSelectionModel: Do not change current index of mapped model if the mapped one is invalid

2013-09-24 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112756/#review40705 --- Ship it! Ship It! - Stephen Kelly On Sept. 16, 2013, 1:56 p

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
> On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: > > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 > > > > > > My initial reaction is that it could return a bool wether or not things > > went okay, g

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Aurélien Gâteau
> On Sept. 24, 2013, 4:23 p.m., Sune Vuorela wrote: > > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 > > > > > > My initial reaction is that it could return a bool wether or not things > > went okay, g

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40694 --- Probably we'll need an extra patch on top of this one so that K

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40692 --- tier1/kguiaddons/src/lib/colors/kcolorutils.cpp

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 24, 2013, 2:19 p.m.) Review request for KDE Frameworks and

Re: Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Tuesday 24 September 2013 13:51:57 Albert Astals Cid wrote: > El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va > > escriure: > > On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > > > Hi all, > > > > > > We're planning to merge the frameworks-scratch branch o

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Albert Astals Cid
El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: > On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > > Hi all, > > > > We're planning to merge the frameworks-scratch branch of kde-workspace > > into > > master next Monday. That means if you're buildin

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: > Hi all, > > We're planning to merge the frameworks-scratch branch of kde-workspace into > master next Monday. That means if you're building your Plasma yourself from > Git (and you're not yet ready for Plasma2 ;)), you should switch