Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40635 --- I'm not sure we can let that in for kdelibs 4.x / kdeui... Davi

Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac

2013-09-23 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/#review40588 --- Ship it! Ship It! - Sune Vuorela On Sept. 21, 2013, 7:53 a.

Re: Review Request 112852: Proposed patch to enable compilation of nepomuk-core on Mac

2013-09-23 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112852/#review40585 --- I'm okay with this, but I'm not well versed with cmake magic. I

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 2:43 p.m.) Review request for KDE Frameworks and

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40571 --- looks ok to me know. Better add the frameworks review group as

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:51 p.m.) Review request for kdelibs. Changes

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40565 --- kdeui/colors/kcolorschemetoken.h

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:04 p.m.) Review request for kdelibs. Changes

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 1:04 p.m.) Review request for kdelibs. Changes

Re: Review Request 112869: Do not leak sockets in kdelibs

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40559 --- This review has been submitted with commit 6e3827c37add0cb92cd

Re: Review Request 112869: Do not leak sockets in kdelibs

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40558 --- This review has been submitted with commit 8791daf6c46e57c3760

Re: Review Request 112869: Do not leak sockets in kdelibs

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 23, 2013, 12:43 p.m.) Status -- This change has been m

Re: Review Request 112869: Do not leak sockets in kdelibs

2013-09-23 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/#review40556 --- Ship it! Ship It! - Lukáš Tinkl On Sept. 22, 2013, 2:21 p.m

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40547 --- Are you sure you've uploaded a new diff? Reviewboard shows no c

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 11:55 a.m.) Review request for kdelibs. Changes

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-23 Thread Kevin Ottens
> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review40505 --- Any reason why this patch isn't committed yet? Please do so ASA

Re: Review Request 109551: port KPtyProcess to QProcess

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- (Updated Sept. 23, 2013, 8:31 a.m.) Status -- This change has been di

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40494 --- kdeui/colors/kcolorschemetoken.h