Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 22, 2013, 4:09 p.m.) Review request for kdelibs. Changes

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
> On Sept. 22, 2013, 1:55 p.m., Kevin Krammer wrote: > > The main question is still opened: can we make needed enums make usable within Q_INVOKABLE function? It will be much simplier in implementation for enduser. - Denis --- This is a

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
> On Sept. 22, 2013, 1:55 p.m., Kevin Krammer wrote: > > kdeui/colors/kcolorschemetoken.h, line 55 > > > > > > a property with a setter but no NOTIFYlooks wrong to me for a QML > > wrapper All of the first seven

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40458 --- kdeui/colors/kcolorschemetoken.h

Re: Review Request 112869: Do not leak sockets in kdelibs

2013-09-22 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112869/ --- (Updated Sept. 22, 2013, 12:21 p.m.) Review request for kdelibs and Solid.

Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- Review request for kdelibs. Description --- It is wrapper to access K

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 22, 2013, 10:17 a.m.) Review request for kdelibs. Changes

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-22 Thread Jaime Torres Amate
> On Sept. 21, 2013, 6:40 p.m., Jaime Torres Amate wrote: > > I've tried to apply it to today master head and it does not apply clean. > > Some previous patch has done something similar to your patch. (sorry, not > > much time to check it all). > > Jonathan Marten wrote: > Is the definitiv

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-22 Thread Jonathan Marten
> On Sept. 21, 2013, 6:40 p.m., Jaime Torres Amate wrote: > > I've tried to apply it to today master head and it does not apply clean. > > Some previous patch has done something similar to your patch. (sorry, not > > much time to check it all). Is the definitive source base and master branch t