Re: Regression in CMake breaking builds

2013-09-15 Thread Ben Cooksley
On Mon, Sep 16, 2013 at 5:24 AM, Stephen Kelly wrote: > Alexander Neundorf wrote: >> It looks like it is related to using imported targets in try_compile(): >> >> -- Enabling c++0x support for unordered map >> CMake Error at cmTryCompileExec236800853Targets.cmake:96 (add_library): >> add_library

Re: Regression in CMake breaking builds

2013-09-15 Thread Stephen Kelly
Alexander Neundorf wrote: > It looks like it is related to using imported targets in try_compile(): > > -- Enabling c++0x support for unordered map > CMake Error at cmTryCompileExec236800853Targets.cmake:96 (add_library): > add_library cannot create imported target "Qt4::QtGui" because another >

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ --- (Updated Sept. 15, 2013, 3 p.m.) Status -- This change has been marke

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40070 --- This review has been submitted with commit 61815341d9761068e3c

Re: Regression in CMake breaking builds

2013-09-15 Thread Ben Cooksley
On Sun, Sep 15, 2013 at 11:30 PM, Alexander Neundorf wrote: > On Sunday 15 September 2013, Ben Cooksley wrote: >> On Sun, Sep 15, 2013 at 10:52 PM, Alexander Neundorf > wrote: >> > On Sunday 15 September 2013, Ben Cooksley wrote: >> >> Hi all, >> >> >> >> It appears that a recent update to CMake

Re: Regression in CMake breaking builds

2013-09-15 Thread Alexander Neundorf
On Sunday 15 September 2013, Ben Cooksley wrote: > On Sun, Sep 15, 2013 at 10:52 PM, Alexander Neundorf wrote: > > On Sunday 15 September 2013, Ben Cooksley wrote: > >> Hi all, > >> > >> It appears that a recent update to CMake on build.kde.org has broken a > >> number of KDE projects, resulting

Re: Regression in CMake breaking builds

2013-09-15 Thread Ben Cooksley
On Sun, Sep 15, 2013 at 10:52 PM, Alexander Neundorf wrote: > On Sunday 15 September 2013, Ben Cooksley wrote: >> Hi all, >> >> It appears that a recent update to CMake on build.kde.org has broken a >> number of KDE projects, resulting in them now failing to build. >> >> An example can be found he

Re: Regression in CMake breaking builds

2013-09-15 Thread Alexander Neundorf
On Sunday 15 September 2013, Ben Cooksley wrote: > Hi all, > > It appears that a recent update to CMake on build.kde.org has broken a > number of KDE projects, resulting in them now failing to build. > > An example can be found here: > http://build.kde.org/view/FAILED/job/kdevplatform_master/560/

Regression in CMake breaking builds

2013-09-15 Thread Ben Cooksley
Hi all, It appears that a recent update to CMake on build.kde.org has broken a number of KDE projects, resulting in them now failing to build. An example can be found here: http://build.kde.org/view/FAILED/job/kdevplatform_master/560/consoleText The following projects appear to be affected at th

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40047 --- Ship it! Thanks! - David Faure On Sept. 14, 2013, 10:36 p.m

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
> On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > > staging/kio/src/core/slavebase.h, line 23 > > > > > > I'm pretty sure it was included already, via one of the kio/* includes > > below. You can just remove t