Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-30 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/#review38980 --- Doh! I did a typo: review 112325 has been submitted, not this o

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Aug. 31, 2013, 6:49 a.m.) Status -- This change has been mar

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/#review38979 --- This review has been submitted with commit 03ff75f2ad70bf2bccf

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-30 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38968 --- Ship it! Well, why not commit it now, and if it ends up slow w

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38954 --- Ship it! minus the unrelated change that got pulled it acciden

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-30 Thread Àlex Fiestas
> On Aug. 30, 2013, 12:29 a.m., Michael Pyne wrote: > > The change seems reasonable (but keep in mind it makes one of the hottest > > methods in KIconLoader that much slower). > > > > However I thought the KCM for the Desktop Theme Appearance already reset > > the cache as suggested by Aleix.

Re: Review Request 112200: Remove unused CMake qimageblitz includes and links

2013-08-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112200/#review38935 --- Ship it! Confirmed with http://lxr.kde.org/ident?i=Blitz - Da