Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38906 --- The change seems reasonable (but keep in mind it makes one of t

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38905 --- Yes it makes sense, although probably we should just nuke the c

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38893 --- Looks good to me, but someone else should approve. - David Edm

Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- Review request for KDE Frameworks, kdelibs and Michael Pyne. Description -

Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

2013-08-29 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112328/ --- Review request for Dolphin and kdelibs. Description --- There are num

Re: Review Request 112351: Application jobs dataengine for KF5

2013-08-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112351/#review38839 --- This review has been submitted with commit 6361c4e1f10c87c0649

Re: Review Request 112351: Application jobs dataengine for KF5

2013-08-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112351/ --- (Updated Aug. 29, 2013, 12:21 p.m.) Status -- This change has been ma

Re: Review Request 112351: Application jobs dataengine for KF5

2013-08-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112351/#review38838 --- Ship it! Ship It! - Sebastian Kügler On Aug. 29, 2013, 8:55

Review Request 112200: Remove unused CMake qimageblitz includes and links

2013-08-29 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112200/ --- Review request for kde-workspace. Description --- No source files in

Review Request 112351: Application jobs dataengine for KF5

2013-08-29 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112351/ --- Review request for kde-workspace. Description --- Enable applicationj