Re: Review Request 111794: collect up to 100 system notifications

2013-08-26 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111794/ --- (Updated Aug. 26, 2013, 7:37 p.m.) Review request for kde-workspace and Gi

Review Request 112294: Implement multi-seat support in KDM

2013-08-26 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112294/ --- Review request for kde-workspace. Description --- This patch implemen

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38644 --- This review has been submitted with commit 7f42bf2530090526d01

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/ --- (Updated Aug. 26, 2013, 1:51 p.m.) Status -- This change has been mar

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38634 --- Ship it! Thanks! I'll commit it. kdecore/services/kservice.c

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/ --- (Updated Aug. 26, 2013, 1:08 p.m.) Review request for kdelibs. Changes -

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread Mathias Tillman
> On Aug. 26, 2013, 12:27 p.m., David Faure wrote: > > kdecore/services/kservice.cpp, line 236 > > > > > > Ah, I forgot to ask: why this check? > > > > Surely the same applies to parts and plugins, doesn'

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Bhushan Shah
> On Aug. 26, 2013, 11:29 a.m., David Edmundson wrote: > > plasma/generic/dataengines/dict/CMakeLists.txt, line 11 > > > > > > We try to avoid extra whitespace in files. > > You have a blank space after plasma_

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38630 --- This review has been submitted with commit b761d846ac6579a3086

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 12:55 p.m.) Status -- This change has been ma

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38615 --- kdecore/services/kservice.cpp

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38611 --- Ship it! I now extended the unittest in keditfiletype to test

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38609 --- Ship it! Two minor comments. plasma/generic/dataengines/dict

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38608 --- Ship it! please fix the whitespace and commit. Thanks! plas

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/ --- (Updated Aug. 26, 2013, 11:09 a.m.) Review request for kde-workspace. De

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38600 --- plasma/generic/dataengines/dict/CMakeLists.txt

Re: KDE theme colors API for QML

2013-08-26 Thread Денис Купляков
> Yes, changing the KColorScheme ABI is not possible for 4.x, you may want to > take this to kde-frameworks-devel for 5.x though. > > Regarding your problem, have you tried something like > > > #include "kcolorscheme.h" > > class ColorSchemeWrapper : public QObject { > Q_OBJECT > Q_ENUMS(ColorSet