Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- Hm, on the face of it, this patch doesn't really make sense ...

Re: Review Request 112234: Save krunner dialog size when manually resized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Aug. 24, 2013, 2:48 p.m.) Review request for kde-workspace. Des

Re: Review Request 112235: Move focus to search field upon typing from result list

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Aug. 24, 2013, 2:42 p.m.) Review request for kde-workspace. Cha

Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- Review request for kde-workspace, Plasma and Eike Hein. Description --

Frameworks API Documentation

First attempt is up: http://api.kde.org/frameworks/kdelibs-apidocs/ Please test it out and let me know what I forgot. I'm working on Search still so I know that's broken.

Re: KF5 kwallet, kwalletd and wallet manager questions

On Saturday, 2013-08-24, Albert Astals Cid wrote: > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > > Hello, > > > > Now that frameworks splitting is almost done ;-) with some people even > > running KF5-based sessions on their systems, I'd like to plan kwallet > > po

Re: KF5 kwallet, kwalletd and wallet manager questions

El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > Hello, > > Now that frameworks splitting is almost done ;-) with some people even > running KF5-based sessions on their systems, I'd like to plan kwallet > porting and integration. BTW, I'd like also to announce that I a

Re: Review Request 112235: Move focus to search field upon typing from result list

> On Aug. 24, 2013, 11:15 a.m., Martin Gräßlin wrote: > > what about cursor up/down keys? You probably want to stay in the results > > list when using those. pageup/down, home, end, evtl. some modified events (shortcuts)? - Thomas ---

Re: Review Request 112235: Move focus to search field upon typing from result list

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/#review38471 --- what about cursor up/down keys? You probably want to stay in th

Re: Review Request 112236: krunner: Add the full name of completion matches to history

> On Aug. 24, 2013, 12:08 p.m., Thomas Lübking wrote: > > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 > > > > > > ... ;-) > > Harald Hvaal wrote: > yeah, not sure what happened

KF5 kwallet, kwalletd and wallet manager questions

Hello, Now that frameworks splitting is almost done ;-) with some people even running KF5-based sessions on their systems, I'd like to plan kwallet porting and integration. BTW, I'd like also to announce that I agreed with Michael Leupold to take over the maintainership of KWallet and I'm now comm

Re: Review Request 112236: krunner: Add the full name of completion matches to history

> On Aug. 24, 2013, 10:08 a.m., Thomas Lübking wrote: > > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 > > > > > > ... ;-) yeah, not sure what happened with post-review here, but it'

Re: Review Request 112236: krunner: Add the full name of completion matches to history

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38466 --- kwin/clients/aurorae/themes/plastik/package/contents/ui/main.q

Re: Review Request 112234: Save krunner dialog size when manually resized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/#review38463 --- To encouter the destructor, the object has to be really destroy

Review Request 112236: krunner: Add the full name of completion matches to history

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/ --- Review request for kde-workspace and Plasma. Description --- Previous

Review Request 112235: Move focus to search field upon typing from result list

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- Review request for kde-workspace. Description --- Upon typing after h

Review Request 112234: Save krunner dialog size when manually resized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- Review request for kde-workspace. Description --- This size was previ