Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-21 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/ --- (Updated Aug. 21, 2013, 10:25 p.m.) Review request for kdelibs. Changes

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38307 --- kded/kbuildservicefactory.cpp

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38306 --- Hmm, what's the bug number? 321706 doesn't exist, must be a typ

Re: Review Request 111951: Fix where some file type associations can't be changed anymore

2013-08-21 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38305 --- I guess what Thomas meant is not that you should use QStringLi

Re: kio and KDirNotify for remote protocols

2013-08-21 Thread Sven Brauch
On Wednesday 21 August 2013 23:23:35 David Faure wrote: > You could listen to the KDirNotify signal leftDirectory(url). Awesome, thanks.

Re: kio and KDirNotify for remote protocols

2013-08-21 Thread David Faure
On Wednesday 21 August 2013 22:47:58 Sven Brauch wrote: > Hi! > > On Wednesday 21 August 2013 22:37:31 David Faure wrote: > > No, which is why people typically create a kded module for the purpose of > > such always-running watching and notifying. > > Ok, then this is probably what I'm going to d

Re: Update on git repository "logical" branch module groups

2013-08-21 Thread David Faure
On Monday 12 August 2013 14:21:57 Michael Pyne wrote: > I'd like for people (especially those working on frameworks or just trying > to huddle to KDE 4) to go ahead and test this. Hi Michael, thanks for the branch-group support ! Here's my testing. I added branch-group kf5-qt5 to the global se

Re: kio and KDirNotify for remote protocols

2013-08-21 Thread Sven Brauch
Hi! On Wednesday 21 August 2013 22:37:31 David Faure wrote: > No, which is why people typically create a kded module for the purpose of > such always-running watching and notifying. Ok, then this is probably what I'm going to do, too. > I don't really follow this one. The URLs have to match as yo

Re: kio and KDirNotify for remote protocols

2013-08-21 Thread David Faure
On Wednesday 14 August 2013 11:53:43 Sven Brauch wrote: > Hi! > > I'm writing a KIO slave for the infinote protocol [1]. The protocol features > push-notifications for connected clients when a file is added or removed, > and it's sort of important for the user to see when files are added. Thus, >

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/#review38288 --- This review has been submitted with commit 64505f15b9725d3d213

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/ --- (Updated Aug. 21, 2013, 4:50 p.m.) Status -- This change has been mar

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/#review38287 --- This review has been submitted with commit ab7b64e3a9c788814bd

Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

2013-08-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/#review38285 --- Ship it! looks good to me - Marco Martin On Aug. 17, 2013,

Re: Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112173/#review38268 --- This review has been submitted with commit 4e04319afc77bfb6628

Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112173/ --- Status -- This change has been marked as submitted. Review request fo

Re: Review Request 112173: Do not use QFileInfo to obtain the size of a symlink in kio_trash

2013-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112173/#review38259 --- Ship it! Ah I see. Sorry, I misunderstood. But yes I very much