Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-17 Thread Raphael Kubo da Costa
Milian Wolff writes: > Btw, is there still no BSD using clang by default to build KDE? How > did they manage to get this to work without the patch? FreeBSD's the first BSD to move towards having clang as the official compiler in future releases. We've been patching FindKDE4Internal.cmake locally

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110090/ --- (Updated Aug. 17, 2013, 11:29 p.m.) Status -- This change has been ma

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110090/#review38050 --- This review has been submitted with commit 31fcc46fd920ab41c14

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-17 Thread Raphael Kubo da Costa
> On May 8, 2013, 5:57 p.m., Raphael Kubo da Costa wrote: > > Thanks for the cleanup. You might also want to remove the references to > > Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated > > anyway. Please include a descriptive commit message explaining that this > > p

Re: Update on git repository "logical" branch module groups

2013-08-17 Thread Ben Cooksley
On Tue, Aug 13, 2013 at 6:21 AM, Michael Pyne wrote: > Hi all, > > (please keep discussion on core-devel) > > A couple of weeks ago at Akademy a decision was reached to allow for the > changing of the kde-workspace development branch for KF5 efforts to be > 'master' (instead of 'frameworks' as in

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 17, 2013, 7:45 p.m.) Status -- This change has been mar

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review38042 --- This review has been submitted with commit 14e2ff5b7359d572cd5

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Michael Bohlender
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review38038 --- Ship it! sorry for taking so long. I applied the patch and eve

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-17 Thread Andrius da Costa Ribas
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > kioslave/thumbnail/windowsexecreator.h, line 30 > > > > > > style issue: check that you keep the eol at the end of the file (your > > patch seems to have

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-17 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/ --- (Updated Aug. 17, 2013, 1:43 p.m.) Review request for KDE Runtime, kdewin

Re: Review request: kde-runtime/kwalletd branch kwalletd-gpg

2013-08-17 Thread Albert Astals Cid
El Dissabte, 17 d'agost de 2013, a les 14:22:35, Valentin Rusu va escriure: > Hello, > > kwalletd now supports GPG encryption. The code is fully functional, at > least on my system, and I pushed it to the kwalletd-gpg branch of > kde-runtime. > See my blog post for more information: > http://www.r

Review request: kde-runtime/kwalletd branch kwalletd-gpg

2013-08-17 Thread Valentin Rusu
Hello, kwalletd now supports GPG encryption. The code is fully functional, at least on my system, and I pushed it to the kwalletd-gpg branch of kde-runtime. See my blog post for more information: http://www.rusu.info/wp/?p=248 I'd like now to ask you to review the code before merging it to the ma

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-08-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/#review38015 --- Hmm, not sure about it, the packages were defined as archives w