Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-14 Thread Andrius da Costa Ribas
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? > > Pa

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37796 --- Shouldn't there be a CMakeLists.txt to install it? - David Edm

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37785 --- Ship it! - David Edmundson On Aug. 14, 2013, 3:26 p.m., Auré

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/ --- (Updated Aug. 14, 2013, 5:26 p.m.) Review request for kdelibs and David Ed

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread Aurélien Gâteau
> On Aug. 14, 2013, 4:46 p.m., David Edmundson wrote: > > I'm not sure why I'm singled out as one of the "notable users"; everyone > > should use this - it's awesome. > > It is definitely worth including. > > > > I've got some minor comments. I singled you out because you have been selling rev

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37764 --- I'm not sure why I'm singled out as one of the "notable users";

Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/ --- Review request for kdelibs and David Edmundson. Description --- Add r

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Aurélien Gâteau
> On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. > > Aurélien Gâteau wrote: > I just grepped in kdepim, it seems only kmail-mobile makes use of it. It > looks like it's working, but I am not fami

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-14 Thread Gabi Sarkis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/ --- (Updated Aug. 14, 2013, 12:56 p.m.) Status -- This change has been ma

kio and KDirNotify for remote protocols

2013-08-14 Thread Sven Brauch
Hi! I'm writing a KIO slave for the infinote protocol [1]. The protocol features push-notifications for connected clients when a file is added or removed, and it's sort of important for the user to see when files are added. Thus, I'd like to make the application using the slave (e.g. dolphin) r

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-14 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/ --- (Updated Aug. 14, 2013, 8:30 a.m.) Review request for kdelibs and KDE Util

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Michael Bohlender
> On Aug. 14, 2013, 7:30 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 5bab478dd04d85a6017c54bc986bcf0b9e235264 by Michael Bohlender to branch > > master. > > Stephen Kelly wrote: > What is this about? Was it pushed to a local clone or so? I fucked up and use

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Stephen Kelly
> On Aug. 14, 2013, 7:30 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 5bab478dd04d85a6017c54bc986bcf0b9e235264 by Michael Bohlender to branch > > master. What is this about? Was it pushed to a local clone or so? - Stephen -

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review37748 --- Ship it! Ship It! - Stephen Kelly On Aug. 14, 2013, 7:30 a.

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review37747 --- This review has been submitted with commit 5bab478dd04d85a6017

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 14, 2013, 7:30 a.m.) Status -- This change has been mar