Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/#review37740 --- Don't put QChar in your structures. That makes them non-POD. Us

Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/ --- Review request for kdelibs and KDE Utils. Description --- Attached pa

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks > > Yuri Chornoivan wrote: > Just commit it into the repo or ask someone to do it for you. > > Commit message should c

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks > > Yuri Chornoivan wrote: > Just commit it into the repo or ask someone to do it for you. > > Commit message should co

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks > > Yuri Chornoivan wrote: > Just commit it into the repo or ask someone to do it for you. > > Commit message should c

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks Just commit it into the repo or ask someone to do it for you. Commit message should contain a separate string "REVIEW: 111952" to c

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: > > Ship It! Sorry about that. How do I go about "Shipping it"? Thanks - Gabi --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#re

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#review37713 --- Ship it! Ship It! - Gabi Sarkis On Aug. 8, 2013, 7:12 p.m.,

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

> On Aug. 9, 2013, 12:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. > > Aurélien Gâteau wrote: > I just grepped in kdepim, it seems only kmail-mobile makes use of it. It > looks like it's working, but I am not fam

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:59 p.m.) Review request for kdelibs, Michael Boh

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

> On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar with this application so I am

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:57 p.m.) Review request for kdelibs and Stephen

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:31 p.m.) Status -- This change has been mar

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37701 --- This review has been submitted with commit 66a27efd6900709b421

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37700 --- Ship it! Ship It! - Sebastian Kügler On Aug. 13, 2013, 3:16

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:16 p.m.) Review request for kde-workspace and Ma

KF5 Update Meeting Minutes 2013-w33

Hello everyone, This is the minutes of the Week 33 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, mck182, mgraesslin, sebas, shadeslayer, vHanda, wojtask9 and myself. Announcement: * Focus for the coming week is on closing

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37698 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:01 p.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37696 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 12:37 p.m.) Review request for kde-workspace and M

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37677 --- Is good. however is not really for master since is about to swi

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37675 --- It's looking good already, a few stylistic remarks inline, and

Re: Review Request 111992: Activity bar in QML.

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41 > > > > > > If you want to optimise, you can make TabBar the root item. > >

Re: Review Request 111992: Activity bar in QML.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37672 --- Looks good to me. Wait for Marco or Sebas to tell you to Ship i

Re: Review Request 111992: Activity bar in QML.

> On Aug. 11, 2013, 11:39 p.m., David Edmundson wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 41 > > > > > > If you want to optimise, you can make TabBar the root item. > >

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? > > Pa

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

> On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? > > Pa

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? > > Pa