Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-12 Thread Pali Rohár
> On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? In des

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 4:11 a.m.) Review request for kde-workspace and Ma

Review Request 112042: Fix for Konqueror crash when adding/importing bookmarks

2013-08-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112042/ --- Review request for KDE Base Apps and David Faure. Description --- Thi

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-12 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#review37625 --- Ship it! Looks good to me. - Jeremy Paul Whiting On Aug. 8,

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-12 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here? - Patrick -

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-12 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review37623 --- kioslave/thumbnail/CMakeLists.txt

Review Request 112038: Look for LibAttica where needed

2013-08-12 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ --- Review request for kdelibs and Stephen Kelly. Description --- The iss

Update on git repository "logical" branch module groups

2013-08-12 Thread Michael Pyne
Hi all, (please keep discussion on core-devel) A couple of weeks ago at Akademy a decision was reached to allow for the changing of the kde-workspace development branch for KF5 efforts to be 'master' (instead of 'frameworks' as in kdelibs). In exchange we would implement a means for users to g

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-12 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37598 --- Ship it! Code looks good. Can you please "forward" this patch

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-12 Thread Matěj Laitl
> On July 22, 2013, 2:57 p.m., Lukáš Tinkl wrote: > > The problem is that udisks2 no longer associates drives with a block > > device, nothing we can circumvent. > > Christoph Feck wrote: > Does commit b92df276 ("Do not clean the cache in UDisks2 backend") work > around this udisks2 issue,

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 12, 2013, 10:30 a.m.) Review request for kde-workspace and M

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
> On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 44 > > > > > > Here there is an old issue of TabBar that should be addressed one day > >

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Marco Martin
> On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 37 > > > > > > whitespace s your friend > > > > for (i=0; ihttp://git.reviewboar

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37558 --- plasma/generic/applets/activitybar/package/contents/ui/main.qm