Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 11, 2013, 2:48 a.m.) Review request for kde-workspace and Ma

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/ --- (Updated Aug. 11, 2013, 2:24 a.m.) Review request for KDE Runtime, kdewin

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/ --- (Updated Aug. 11, 2013, 2:23 a.m.) Review request for KDE Runtime, kdewin

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/ --- (Updated Aug. 11, 2013, 2:23 a.m.) Review request for KDE Runtime, kdewin

Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/ --- Review request for KDE Runtime, kdewin and Pali Rohár. Description ---

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 10, 2013, 5:28 p.m.) Review request for kde-workspace and Ma

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
> On Aug. 10, 2013, 5:04 p.m., David Edmundson wrote: > > Good start. > > > > You shouldn't delete the Messages.sh file. > > Copy from something that already uses QML, such as the battery applet. > > > > There's also a change from the current behaviour. The current one only > > shows where sta

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37476 --- Good start. You shouldn't delete the Messages.sh file. Copy fr

Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- Review request for kde-workspace and Marco Martin. Description --- Ac

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-10 Thread Christoph Feck
> On July 22, 2013, 12:57 p.m., Lukáš Tinkl wrote: > > The problem is that udisks2 no longer associates drives with a block > > device, nothing we can circumvent. Does commit b92df276 ("Do not clean the cache in UDisks2 backend") work around this udisks2 issue, in other words, is this patch no