Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Mark Gaiser
> On Aug. 5, 2013, 11:02 p.m., David Faure wrote: > > kdecore/io/kdirwatch.cpp, line 313 > > > > > > You can remove the "? true : false" bit. Ahh lol, i didn't even notice that! How stupid of me. Comparing a bool

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37170 --- Good catch. Just a few suggestions for improvement. kdecore/i

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-05 Thread Alex Merry
On 05/08/13 20:55, Milian Wolff wrote: > I'm out of the loop, since this is so close to the final release I'm not sure > whether I should get this in... I'd say commit it; the patch is pretty trivial, and I can't see any way it could break the build for anyone not using Clang, and build fixes are

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/ --- (Updated Aug. 5, 2013, 8:17 p.m.) Review request for kdelibs and David Fau

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Mark Gaiser
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote: > > kdecore/io/kdirwatch.cpp, line 372 > > > > > > the indentation is broken here, no? should be two spaces like the rest > > of the file. > > Mark Gaiser wrote

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-05 Thread Milian Wolff
On Monday 05 August 2013 19:17:49 Albert Astals Cid wrote: > El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure: > > On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: > > > El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > > > > On Sunday 04

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Milian Wolff
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote: > > kdecore/io/kdirwatch.cpp, line 372 > > > > > > the indentation is broken here, no? should be two spaces like the rest > > of the file. > > Mark Gaiser wrote

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/ --- (Updated Aug. 5, 2013, 5:30 p.m.) Review request for kdelibs and David Fau

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-05 Thread Albert Astals Cid
El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure: > On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: > > El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > > > On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: > > > > Hey all, > > > > >

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37138 --- This review has been submitted with commit 09030c36b2e5da244c4

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/ --- (Updated Aug. 5, 2013, 3:26 p.m.) Status -- This change has been mark

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/ --- (Updated Aug. 5, 2013, 3:14 p.m.) Review request for kdelibs, Albert Astal

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37133 --- kdecore/services/kmimetype_p.h

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Narváez
> On Aug. 5, 2013, 7:46 a.m., David Faure wrote: > > kdecore/services/kmimetype_p.h, line 48 > > > > > > Why did you make this a new virtual method? > > The concept doesn't exist in KServiceType, so I don't see

Re: Review Request 111145: Execute initModules on recreateDone

2013-08-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/45/ --- (Updated Aug. 5, 2013, 1:26 p.m.) Status -- This change has been mark

Re: Proposed schedule for 4.12

2013-08-05 Thread Allen Winter
On Saturday, August 03, 2013 08:19:48 PM Albert Astals Cid wrote: > Please let's try to keep this discussion in release-team, I'm just CC'ing k-c- > d because Alex's discussion about changing the release happened there. > > At the Release Team BoF at Akademy I was tasked to come up with a proposed

Re: Review Request 111883: Fix runtime regression caused by the fix for #134960

2013-08-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111883/ --- (Updated Aug. 5, 2013, 11:58 a.m.) Status -- This change has been mar

Re: Review Request 111883: Fix runtime regression caused by the fix for #134960

2013-08-05 Thread Dawit Alemayehu
> On Aug. 5, 2013, 7:50 a.m., David Faure wrote: > > Looks good, please also revert the NoGUI->GUI changes to the unittests. This review has been submitted with commit 9b0b5ec1a6396b051f65bf23cdf9d9949aa9c3ec by Dawit Alemayehu to branch KDE/4.11. - Dawit ---

Re: Review Request 111883: Fix runtime regression caused by the fix for #134960

2013-08-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111883/ --- (Updated Aug. 5, 2013, 11:55 a.m.) Status -- This change has been mar

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review37114 --- This review has been submitted with commit 9b0b5ec1a6396b051f6

Re: Review Request 111341: Oxygenify KNetattach

2013-08-05 Thread Rohan Garg
> On July 9, 2013, 12:17 a.m., Pino Toscano wrote: > > The patch is wrong. > > > > It is correct for knetattach to have an own icon and to use it its own > > code. If you want an Oxygen version of this icon, then create one (named > > "knetattach") and add it to the Oxygen icon theme, which wi

Re: Review Request 111341: Oxygenify KNetattach

2013-08-05 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- (Updated Aug. 5, 2013, 3:37 p.m.) Status -- This change has been disc

Re: Proposed schedule for 4.12

2013-08-05 Thread Àlex Fiestas
Looks ok, thanks for the work dude!

Re: Review Request 111883: Fix runtime regression caused by the fix for #134960

2013-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111883/#review37102 --- Ship it! Looks good, please also revert the NoGUI->GUI changes

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37101 --- Thanks for the unittest. Almost there :) kdecore/services/kmi