Review Request 111883: Fix runtime regression caused by the fix for #134960

2013-08-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111883/ --- Review request for kdelibs, Albert Astals Cid and David Faure. Description

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-04 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/ --- (Updated Aug. 5, 2013, 1:38 a.m.) Review request for kdelibs, Albert Astal

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

2013-08-04 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/ --- (Updated Aug. 5, 2013, 1:37 a.m.) Review request for kdelibs and David Fau

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-04 Thread Milian Wolff
On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: > El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > > On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: > > > Hey all, > > > > > > I'd like to backport this comment from kdelibs master to KDE 4.11, is > > > th

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-04 Thread Albert Astals Cid
El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: > On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: > > Hey all, > > > > I'd like to backport this comment from kdelibs master to KDE 4.11, is this > > OK? > > Ahum, sorry - accidentally hit "ctrl + enter". > > commit

Re: Broken tests in kdelibs due to kio change

2013-08-04 Thread Albert Astals Cid
El Dissabte, 3 d'agost de 2013, a les 17:14:01, Dawit A va escriure: > Well I do not consider this to be a new dependency, runtime or otherwise The tests disagree with you, they were working, and then they were not, the runtime moved below their feet. > since KIO already has a dependency on QtGu