Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote: > > kdecore/io/kdirwatch.cpp, line 327 > > > > > > why did you move that outside? is this being used elsewhere? if so, I > > can't see it by the diff apparently.

Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

Hey all, I'd like to backport this comment from kdelibs master to KDE 4.11, is this OK? -- Milian Wolff m...@milianw.de http://milianw.de

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: > Hey all, > > I'd like to backport this comment from kdelibs master to KDE 4.11, is this > OK? Ahum, sorry - accidentally hit "ctrl + enter". commit 0bd9529fc3d9382dc748a2f7f5306903c674151c Author: Milian Wolff Date: Sun Jul 21 21:07:36 2

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37041 --- kdecore/io/kdirwatch.cpp

Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/ --- Review request for kdelibs and David Faure. Description --- At first

Re: Broken tests in kdelibs due to kio change

Well I do not consider this to be a new dependency, runtime or otherwise since KIO already has a dependency on QtGui in the current stable branches. In frameworks that is going to be changed such that the core and ui portions will be separated out into their own components. Anyhow, my question was

Re: Broken tests in kdelibs due to kio change

On Saturday 03 August 2013 19:54:45 Albert Astals Cid wrote: > El Dissabte, 3 d'agost de 2013, a les 19:52:28, Albert Astals Cid va escriure: > > El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure: > > > OK. I see why those tests failed and I fixed them not to anymore. > > > Updat

announcement

Heya all, We're working on the announcement text here: https://notes.kde.org/p/release4.11 Feel free to add/correct stuff ;-) Hugs, Jos signature.asc Description: This is a digitally signed message part.

Proposed schedule for 4.12

Please let's try to keep this discussion in release-team, I'm just CC'ing k-c- d because Alex's discussion about changing the release happened there. At the Release Team BoF at Akademy I was tasked to come up with a proposed schedule for 4.12 with simplified freezes, since it was agreed so many f

Re: Broken tests in kdelibs due to kio change

El Dissabte, 3 d'agost de 2013, a les 19:52:28, Albert Astals Cid va escriure: > El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure: > > OK. I see why those tests failed and I fixed them not to anymore. Updating > > the clibpboard in KIO introduced a dependency on QtGui. > > Hence

Re: Broken tests in kdelibs due to kio change

El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure: > OK. I see why those tests failed and I fixed them not to anymore. Updating > the clibpboard in KIO introduced a dependency on QtGui. > Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed > to QTEST_KDEMAIN( KDirModelTe

Re: Broken tests in kdelibs due to kio change

OK. I see why those tests failed and I fixed them not to anymore. Updating the clibpboard in KIO introduced a dependency on QtGui. Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed to QTEST_KDEMAIN( KDirModelTest, GUI ). Hmm... I am curious if the dependency on QClipboard makes it diff

Re: Broken tests in kdelibs due to kio change

Hmm... I fail to see how my changes break those unit tests. Perhaps changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to look into it. On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid wrote: > Dawit, kdelibs people, there are 4 tests that broke in > very-close-to-release >

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review37027 --- I don't see this being important enough to warrant new strings

Broken tests in kdelibs due to kio change

Dawit, kdelibs people, there are 4 tests that broke in very-close-to-release 4.11 branch with a change from yesterday to kio. http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/ Can you guys please have a look and fix those failing tests? Also please please please make sure you

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37022 --- kdecore/services/kmimetype.cpp

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37019 --- Can this be unit tested? - Albert Astals Cid On Aug. 3, 201

Re: Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/#review37020 --- Can this be unit tested? - Albert Astals Cid On Aug. 3, 201

Review Request 111852: Ensure MImeType's XML Data is Loaded before Returning Properties

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111852/ --- Review request for kdelibs and David Faure. Description --- Comment i

Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- Review request for Documentation and KDE Runtime. Description --- The