Re: Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111402/ --- (Updated July 6, 2013, 12:27 a.m.) Status -- This change has been mar

Re: Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111402/#review35652 --- This review has been submitted with commit ff1e67e11800107a81c

Re: Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111402/#review35650 --- Ship it! Looks fine to me, please go ahead. - Ben Cooksley

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > > > > > Please don't put this code in scheduler.cpp > > > > I'm trying to properly split core and gui aspects of KI

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35644 --- This review has been submitted with commit 2dcb46a0334c6c0ceb2

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:54 p.m.) Status -- This change has been mark

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35643 --- Ship it! Looks good to me. Just add "inactive" / "active" in t

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:46 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35642 --- kdeui/util/kglobalsettings.h

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35641 --- So, changes in .cpp reverted, deprecated messages improved and

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:32 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:28 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:28 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated July 5, 2013, 4:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111402/#review35639 --- Yep, I am very much in favour of automatic versioning with KDE_

Review Request 111402: make systemsettings use KDE_VERSION_STRING as its version string instead of the never changing "1.0"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111402/ --- Review request for kde-workspace and Ben Cooksley. Description --- Th

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/#review35635 --- Sounds like the unittest is incomplete then, if it didn't catch

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/#review35634 --- Oh joy, a commit that moves a bunch of code which has changed q

Re: gdk_x_error (was: Re: [kile] [Bug 321759] Kile crashes when file is opened from menu)

>> 2. GDK installs a deadly X error handler, causing the application to >> exit, instead of "just" printing an error message. See multiple >> backtraces containing gdk_x_error[3] There have recently been similar reports for KDevelop, too.

Re: gdk_x_error (was: Re: [kile] [Bug 321759] Kile crashes when file is opened from menu)

On Friday 05 July 2013 Jul 15:06:22 Christoph Feck wrote: > On Friday 05 July 2013 04:01:04 Jekyll Wu wrote: > > https://bugs.kde.org/show_bug.cgi?id=321759 > > > > Actually, I have noticed a few similar 'crash' reports (bug 321931, > > bug 321972, bug 321954) created recently, and all of them are

gdk_x_error (was: Re: [kile] [Bug 321759] Kile crashes when file is opened from menu)

On Friday 05 July 2013 04:01:04 Jekyll Wu wrote: > https://bugs.kde.org/show_bug.cgi?id=321759 > > Actually, I have noticed a few similar 'crash' reports (bug 321931, > bug 321972, bug 321954) created recently, and all of them are from > Ubuntu systems. There are two issues here: 1. The applicat