Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/ --- (Updated July 2, 2013, 2:41 a.m.) Review request for kdelibs and David Fau

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-01 Thread Dawit Alemayehu
> On July 1, 2013, 6:17 p.m., David Faure wrote: > > This will create further trouble, I would say. > > > > What if an application installs several .desktop files, like: > > kmail --attach %U > > kmail --view %U > > kmail --check > > kmail --erase-my-harddisk > > > > By typing "kmail" i

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35402 --- Looks like the proper source, but i guess the icon should be ra

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-01 Thread Thomas Lübking
> On July 1, 2013, 2:39 p.m., Kevin Ottens wrote: > > kdeui/util/kglobalsettings.h, line 265 > > > > > > I think it's fine. lxr.kde.org seem to indicate that those colors got > > abused at some places anyway, and

KIO progress towards tier 1 framework?

2013-07-01 Thread Mark
Hi, When i'm looking in the kdelibs splitting document [1] i only see KIO pop up twice. One to get kbookmarks out of KIO (which is work in progress). Another one with "kio-core" as work in progress. But i can't find any documentation anywhere that gives me a clear view as to how far KIO is on it'

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/#review35391 --- This will create further trouble, I would say. What if an appl

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 5:17 p.m.) Review request for kde-workspace, KInfoC

Review Request 111345: KParts::StatusBarExtension: Remember activated state

2013-07-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/ --- Review request for kdelibs and David Faure. Description --- When the

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35374 --- from my side it looks OK, though I won't give a ship-it. This i

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- (Updated July 1, 2013, 8:42 p.m.) Review request for KDE Runtime. Change

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35358 --- kdeui/util/kglobalsettings.h

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated July 1, 2013, 1:14 p.m.) Review request for kde-workspace and kwi

Re: Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35352 --- knetattach/knetattach.cpp

Re: Review Request 111291: New Windows solid backend

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/#review35350 --- This review has been submitted with commit 68b4b73681337e73c8b

Re: Review Request 111291: New Windows solid backend

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/ --- (Updated July 1, 2013, 12:56 p.m.) Status -- This change has been mar

Re: kentrymaptest broken in master

2013-07-01 Thread David Faure
Le lundi 1 juillet 2013 00:14:32 Albert Astals Cid a écrit : > Hi, it seems that > https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=0e934088c5 > 647fe3d56f76fdb28d05c0fdf0f7a4 broke kentrymaptest > http://build.kde.org/view/KDE%20SC%20master/job/kdelibs_master/310/testRepor > t/%28

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35347 --- Not that I could comment on whether it's useful or not on Windo

Re: Review Request 111291: New Windows solid backend

2013-07-01 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/#review35346 --- Ship it! Look good, compiles fine on Linux - Lukáš Tinkl On

Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- Review request for kde-workspace and kwin. Description --- make kinfo

Review Request 111341: Oxygenify KNetattach

2013-07-01 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/ --- Review request for KDE Runtime. Description --- Patch from Kubuntu pa

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35344 --- This review has been submitted with commit f4269ef3498581964e8

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated July 1, 2013, 10:55 a.m.) Status -- This change has been mar

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-07-01 Thread Luca Beltrame
In data domenica 30 giugno 2013 15:44:50, Johannes Obermayr ha scritto: > Why don't you drop obsolete patches and waste binaries then? You're welcome to join the discussion in the relevant downstream mailing list, discussion started months ago. This does not however concern KDE. > remove it). T