Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/ --- (Updated July 1, 2013, 5:10 a.m.) Review request for kdelibs. Changes --

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/ --- (Updated July 1, 2013, 3:13 a.m.) Review request for kdelibs. Changes --

Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/ --- Review request for kdelibs. Description --- The attach patch address

kentrymaptest broken in master

Hi, it seems that https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=0e934088c5647fe3d56f76fdb28d05c0fdf0f7a4 broke kentrymaptest http://build.kde.org/view/KDE%20SC%20master/job/kdelibs_master/310/testReport/%28root%29/TestSuite/kentrymaptest/ Can anyone have a look at if we eit

Re: Review Request 111291: New Windows solid backend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/#review35326 --- Ship it! Ship It! - Andre Heinecke On June 28, 2013, 6:05 p

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

> On June 15, 2013, 5:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111050: Fast mime detection speedup.

On Sunday 30 June 2013, Mark Gaiser wrote: > > On June 24, 2013, 9:19 a.m., David Faure wrote: > > > kdecore/services/kmimetype.cpp, line 316 > > > > > line316> > > > > > > I can't review this. It completely forks an exi

Re: Review Request 111050: Fast mime detection speedup.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review35308 --- kdecore/services/kmimetype.cpp

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

> On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111050: Fast mime detection speedup.

> On June 24, 2013, 9:19 a.m., David Faure wrote: > > kdecore/services/kmimetype.cpp, line 316 > > > > > > I can't review this. It completely forks an existing method > > (findByUrlHelper), which is already suppo