Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35158 --- kcheckpass/checkpass_etcpasswd.c

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35155 --- The changes themselves look fine. But kcheckpass/checkpass_osfc

Re: Review Request 110459: Klipper: Allow to keep items in clipboard history

2013-06-26 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110459/#review35154 --- klipper/historyitem.h

Re: Review Request 110459: Klipper: Allow to keep items in clipboard history

2013-06-26 Thread David Faure
> On June 26, 2013, 7:55 p.m., Lamarque Souza wrote: > > klipper/historyitem.h, line 69 > > > > > > add const before "bool", like this: > > > > setKeep(const bool keep) That's rather unusual (check all of

Re: Review Request 110459: Klipper: Allow to keep items in clipboard history

2013-06-26 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110459/#review35140 --- klipper/historyitem.h

Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread mancha mancha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/ --- Review request for kde-workspace. Description --- Background: Beginni

Re: Review Request 111238: Remove .end() calls from iteration loops in KDirLister

2013-06-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111238/#review35114 --- The change itself looks OK, but all it will do is create a giga

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-26 Thread David Faure
Le mardi 25 juin 2013 20:25:10 Albert Astals Cid a écrit : > El Dimarts, 18 de juny de 2013, a les 19:19:24, Albert Astals Cid va escriure: > > El Dimarts, 18 de juny de 2013, a les 09:55:23, David Faure va escriure: > > > Le lundi 17 juin 2013 20:15:23 Albert Astals Cid a écrit : > > > > Maybe we