Review Request 111206: Fix the Delete/Move To Trash actions for remote files

2013-06-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/ --- Review request for KDE Base Apps, David Faure and Frank Reininghaus. Descr

Re: Review Request 111158: Fix KLinkItemSelectionModel handling of QItemSelectionModel::Toggle flag

2013-06-23 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/58/#review34939 --- Ship it! Ship It! - Stephen Kelly On June 21, 2013, 10:45 a

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Thomas Lübking
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 376 > > > > > > unrelated change > > Mark Gaiser wrote: > Well, i changed the function so i took the liberty of upda

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 345 > > > > > > try using QStringRef here to safe allocations if you care about speed. > > Mark Gaiser wrote: > QStr

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated June 23, 2013, 9:21 p.m.) Review request for kdelibs, David Faure

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 376 > > > > > > unrelated change Well, i changed the function so i took the liberty of updating the code style for that

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34926 --- > "KMimeTypePrivate::iconName" is now the one slowing everythin

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34924 --- kdecore/services/kmimetype.cpp

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated June 23, 2013, 6:12 p.m.) Review request for kdelibs, David Faure