Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/ --- (Updated June 18, 2013, 12:24 a.m.) Status -- This change has been ma

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/#review34544 --- This review has been submitted with commit 8aa1fed5bde94e0b71e

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/ --- (Updated June 18, 2013, 12:20 a.m.) Review request for Documentation, kdel

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread T.C. Hollingsworth
> On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: > > imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be > > included by mediaobjectco, which is not ignored but required for the maps. > > The patch removes the imageobjectco.module from the set of ignored modules, > > so

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
> On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: > > imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be > > included by mediaobjectco, which is not ignored but required for the maps. > > The patch removes the imageobjectco.module from the set of ignored modules, > > so

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread T.C. Hollingsworth
> On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: > > imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be > > included by mediaobjectco, which is not ignored but required for the maps. > > The patch removes the imageobjectco.module from the set of ignored modules, > > so

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
> On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: > > imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be > > included by mediaobjectco, which is not ignored but required for the maps. > > The patch removes the imageobjectco.module from the set of ignored modules, > > so

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/#review34535 --- Ship it! imageobjectco, supported since the Paleolitic age in

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/#review34533 --- Ship it! Go ahead, but it's still on your own peril. - Alexan

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
> On June 17, 2013, 6:34 p.m., Alexander Neundorf wrote: > > No other changes at all necessary ? > > Andrea Scarpino wrote: > kdelibs does not use any of the variables listed in the ECM_SiC page Then it's probably ok. - Alexander -

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34453 --- forgot to actually submit this yesterday... lets do it now even

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Milian Wolff
On Monday 17 June 2013 15:44:12 Mark wrote: > On Mon, Jun 17, 2013 at 5:38 PM, David Faure wrote: > > Le lundi 17 juin 2013 15:13:36 Mark a écrit : > >> @Frank, do you happen to know what dolphin does here? Is it passing > >> this mode property? > > > > I thought you profiled this, don't you have

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/ --- (Updated June 17, 2013, 7:53 p.m.) Status -- This change has been mar

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:34 p.m., Alexander Neundorf wrote: > > No other changes at all necessary ? kdelibs does not use any of the variables listed in the ECM_SiC page - Andrea --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34529 --- This review has been submitted with commit 150b19d61dd1e7ce30b

Re: Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111071/ --- (Updated June 17, 2013, 7:50 p.m.) Status -- This change has been mar

Re: Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111071/#review34528 --- This review has been submitted with commit e14a1615da4189cd7f3

Re: Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:33 p.m., Alexander Neundorf wrote: > > http://techbase.kde.org/Development/ECM_SourceIncompatChanges#FindRUBY.cmake > > lists a few changes, but there are none in this patch. So it is not used > > at all within kdelibs ? It's not used. - Andrea ---

Re: Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111067/ --- (Updated June 17, 2013, 7:48 p.m.) Status -- This change has been mar

Re: Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111067/#review34526 --- This review has been submitted with commit 3c76c15b8a7c1602fa6

Review Request 111080: Macro*.cmake changes

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/ --- Review request for kdelibs and Alexander Neundorf. Description --- Ma

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Alexander Neundorf
> On June 17, 2013, 6:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Frank Reininghaus
Hi, 2013/6/17 Mark: > On Mon, Jun 17, 2013 at 4:13 PM, David Faure wrote: >> Le lundi 17 juin 2013 09:54:02 Mark a écrit : [...] >>> However, that >>> stat data isn't send to KMimeType so another way would be to require a >>> "KFileItem" which knows more about a file instead of a KUrl (QUrl in >>>

Re: Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111067/#review34514 --- Ship it! - Alexander Neundorf On June 17, 2013, 3:21 p.m., A

Re: Review Request 111070: Drop internal PostgreSQL cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:32 p.m., Alexander Neundorf wrote: > > It is not used anywhere ? > > http://techbase.kde.org/Development/ECM_SourceIncompatChanges#FindPostgreSQL.cmake > > lists a few renamed variables, but there are no such changes in this patch > > ? It's not. I did run 'fgrep -R' for

Re: Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/#review34519 --- No other changes at all necessary ? - Alexander Neundorf On

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111071/#review34518 --- Ship it! http://techbase.kde.org/Development/ECM_SourceIncompa

Re: Review Request 111070: Drop internal PostgreSQL cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111070/#review34516 --- Ship it! It is not used anywhere ? http://techbase.kde.org/Dev

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34515 --- Ship it! Ship It! - Alexander Neundorf On June 17, 2013, 3:

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Albert Astals Cid
> On June 17, 2013, 6:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. The syntax seems to be a bit different :-/ -# GETTEXT_

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? Those are available in the upstream FindGettext too. - Andrea --- This is an autom

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-17 Thread Albert Astals Cid
El Dilluns, 17 de juny de 2013, a les 13:57:21, David Faure va escriure: > Le lundi 17 juin 2013 01:08:39 Albert Astals Cid a écrit : > > So my path in a Plasma session is > > /usr/lib/x86_64-linux-gnu/qt4/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin > > :/ usr/bin:/sbin:/bin:/usr/games:/usr/local/

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34508 --- What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or

Review Request 111072: Drop internal X11 cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us

Review Request 111071: Drop internal RUBY cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111071/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us

Review Request 111070: Drop internal PostgreSQL cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111070/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/ --- (Updated June 17, 2013, 5:26 p.m.) Review request for kdelibs and Alexande

Review Request 111068: Drop internal Msgfmt

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us

Re: Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111067/ --- (Updated June 17, 2013, 5:21 p.m.) Review request for kdelibs and Alexande

Review Request 111067: Drop internal Flex cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111067/ --- Review request for kdelibs and Alexander Neundorf. Description --- Us

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Mark
On Mon, Jun 17, 2013 at 5:38 PM, David Faure wrote: > Le lundi 17 juin 2013 15:13:36 Mark a écrit : >> @Frank, do you happen to know what dolphin does here? Is it passing >> this mode property? > > I thought you profiled this, don't you have backtraces? I tested KMimeType directly from a file lis

Re: Should fast mime detection use a stat call?

2013-06-17 Thread David Faure
Le lundi 17 juin 2013 15:13:36 Mark a écrit : > @Frank, do you happen to know what dolphin does here? Is it passing > this mode property? I thought you profiled this, don't you have backtraces? > For the rest of this patch. I - sadly - didn't think about looking in > the frameworks branch to see

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Mark
On Mon, Jun 17, 2013 at 4:13 PM, David Faure wrote: > Le lundi 17 juin 2013 09:54:02 Mark a écrit : >> -- sending to kfm-devel as well -- >> >> Hi, >> >> By now some of you have likely seen my reviewrequest [1] that greatly >> speeds up fast mime detection. > > Sure, let's discuss the same thing i

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

2013-06-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/ --- (Updated June 17, 2013, 1:07 p.m.) Review request for KDE Base Apps and Da

Re: Should fast mime detection use a stat call?

2013-06-17 Thread David Faure
Le lundi 17 juin 2013 09:54:02 Mark a écrit : > -- sending to kfm-devel as well -- > > Hi, > > By now some of you have likely seen my reviewrequest [1] that greatly > speeds up fast mime detection. Sure, let's discuss the same thing in reviewboard, and on two different mailing-lists Can we

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-17 Thread David Faure
Le lundi 17 juin 2013 01:08:39 Albert Astals Cid a écrit : > So my path in a Plasma session is > /usr/lib/x86_64-linux-gnu/qt4/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/ > usr/bin:/sbin:/bin:/usr/games:/usr/local/games > > This makes the QT_SELECT thing from qtchooser not work > since if i do

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34480 --- In addition to the issues below, I suspect it changes behavior

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/#review34473 --- This part looks good. You can't remove "deleteOwnedSessions" -

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Mark
On Mon, Jun 17, 2013 at 11:06 AM, Frank Reininghaus wrote: > Hi Mark, > > thanks for looking into these issues. Enabling us to load icons faster > when entering a directory is appreciated :-) > > I can't say much about your proposed changes in kdelibs though - I > think that David will be able to

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Frank Reininghaus
Hi Mark, thanks for looking into these issues. Enabling us to load icons faster when entering a directory is appreciated :-) I can't say much about your proposed changes in kdelibs though - I think that David will be able to give more useful comments. 2013/6/17 Mark: > What's your opinion on thi

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-17 Thread Àlex Fiestas
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-17 Thread Mark Gaiser
> On June 16, 2013, 8:52 p.m., Fredrik Höglund wrote: > > Looks good to me. > > > > Maksim Orlovich suggested that we should look into using lossless WebP for > > images in KDE, > > since WebP has faster decompression than libpng, and produces smaller files. > > > > I've done some tests with O

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-17 Thread Sune Vuorela
On 2013-06-16, Albert Astals Cid wrote: > So my path in a Plasma session is > /usr/lib/x86_64-linux-gnu/qt4/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games > > This makes the QT_SELECT thing from qtchooser not work > since if i do > QT_SELECT=qt5 moc >

Should fast mime detection use a stat call?

2013-06-17 Thread Mark
-- sending to kfm-devel as well -- Hi, By now some of you have likely seen my reviewrequest [1] that greatly speeds up fast mime detection. In fact, the speedup is ~13x over the current situation. I only stopped profiling and further speeding it up because initialization and KGlobal calls began t

Re: K(Abstract)FileItemActionPlugin

2013-06-17 Thread Frank Reininghaus
Hi, 2013/6/14 Thomas Lübking: > On Donnerstag, 13. Juni 2013 16:36:31 CEST, Frank Reininghaus wrote: >> >> Hi, >> >> sorry for the late reply. > > > And sorry myself for similar reasons ;-) > >>> 2013/6/10, Frank Reininghaus: >> >> time explaining users why reassigning the bug away from Dolphin ma