Review Request 111054: allow to be used in KDE Documentation

2013-06-16 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/ --- Review request for Documentation, kdelibs and Luigi Toscano. Description -

Re: Review Request 111054: allow to be used in KDE Documentation

2013-06-16 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111054/ --- (Updated June 17, 2013, 2:12 a.m.) Review request for Documentation, kdeli

Re: Review Request 106300: add kimgio WebP image format plugin

2013-06-16 Thread Michael Reeves
> On May 18, 2013, 8:44 a.m., Commit Hook wrote: > > This review has been submitted with commit > > df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch master. > > Christoph Feck wrote: > Just noticed this has been committed to kolourpaint instead of kdelibs. > Did I miss a

startkde modifies PATH to add qt4 bin dir to the front

2013-06-16 Thread Albert Astals Cid
So my path in a Plasma session is /usr/lib/x86_64-linux-gnu/qt4/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games This makes the QT_SELECT thing from qtchooser not work since if i do QT_SELECT=qt5 moc i still get the /usr/lib/x86_64-linux-gnu/qt4/bin moc

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-16 Thread Thomas Lübking
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-16 Thread Àlex Fiestas
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-16 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34447 --- Ship it! Looks good to me. Maksim Orlovich suggested that we

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-16 Thread Thomas Lübking
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

2013-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/ --- (Updated June 16, 2013, 6:31 p.m.) Status -- This change has been mar

Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

2013-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/#review34445 --- This review has been submitted with commit ef72f8530e579002eb3

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34443 --- Some comments on code. But I agree that this is too late for 4.

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-16 Thread Luca Beltrame
> On June 15, 2013, 5:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
> On June 16, 2013, 4:59 p.m., Sven Brauch wrote: > > While speedup is certainly always great, this sounds dangerous to me: > > > > > I am getting an inconsistency. Using the unpatched fast mime detection on > > > a file like: "test.tar.gz" gets detected as > > > "application-x-compressed-tar"

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Mark Gaiser
> On June 16, 2013, 4:59 p.m., Sven Brauch wrote: > > While speedup is certainly always great, this sounds dangerous to me: > > > > > I am getting an inconsistency. Using the unpatched fast mime detection on > > > a file like: "test.tar.gz" gets detected as > > > "application-x-compressed-tar"

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34437 --- While speedup is certainly always great, this sounds dangerous

Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- Review request for kdelibs, David Faure and Frank Reininghaus. Description

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-16 Thread Àlex Fiestas
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-06-16 Thread Àlex Fiestas
> On May 25, 2013, 5:25 p.m., Àlex Fiestas wrote: > > I'm 100% against this patch, it is a no go. > > > > What we have to provide is a way for distributions to open the wallet in a > > SECURE way without asking the user for a password. Distros are free to use > > this patch but then they shoul

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-06-16 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review34432 --- Ship it! Ship It! - Àlex Fiestas On May 8, 2013, 11:12 p.m.

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-06-16 Thread Sandro Andrade
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/ --- (Updated June 16, 2013, 12:04 p.m.) Status -- This change has been di

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

2013-06-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/ --- (Updated June 16, 2013, 1:46 p.m.) Review request for KDE Base Apps and Da

Review Request 111048: Avoid causing Konqueror from performing lots of stat calls on every auto save session call

2013-06-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/ --- Review request for KDE Base Apps and David Faure. Description --- The

Re: Review Request 106300: add kimgio WebP image format plugin

2013-06-16 Thread Martin Koller
On Sunday 16 June 2013 01:13:13 Christoph Feck wrote: > > > On May 18, 2013, 12:44 p.m., Commit Hook wrote: > > > This review has been submitted with commit > > > df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch > > > master. > > > > Christoph Feck wrote: > > Just noticed

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-16 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Chan

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-16 Thread Martin Gräßlin
> On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc