Review Request 110947: Set the mtime when moving files through sftpCopyGet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110947/ --- Review request for KDE Runtime, Andreas Schneider and David Faure. Descrip

Re: Review Request 110944: Send "modified" metaData when moving files through copy()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110944/ --- (Updated June 10, 2013, 9:41 p.m.) Review request for kdelibs and David Fa

Re: Review Request 110944: Send "modified" metaData when moving files through copy()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110944/#review34095 --- kio/kio/job.cpp

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/ --- (Updated June 10, 2013, 7:57 p.m.) Status -- This change has been mar

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review34089 --- This review has been submitted with commit bf2bb4861fdafc82280

Review Request 110944: Send "modified" metaData when moving files through copy()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110944/ --- Review request for kdelibs and David Faure. Description --- The attac

Re: Review Request 110755: Fix two small memory leaks in kded_keyboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110755/ --- (Updated June 10, 2013, 6:31 p.m.) Status -- This change has been mar

Re: Review Request 110755: Fix two small memory leaks in kded_keyboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110755/#review34077 --- This review has been submitted with commit 82036f008dfe5351586

Re: K(Abstract)FileItemActionPlugin

El Dilluns, 10 de juny de 2013, a les 15:56:16, Frank Reininghaus va escriure: > Hi Albert, > > thanks for the quick reply. > > 2013/6/9 Albert Astals Cid: > > El Diumenge, 9 de juny de 2013, a les 09:22:10, Frank Reininghaus va escriure: > >> Hi Albert, > >> > >> thanks for your comments. > >>

Re: Review Request 106581: Make KFileDialog remember settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review34066 --- This review has been submitted with commit c59c20a325098a55387

Re: Review Request 106581: Make KFileDialog remember settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- (Updated June 10, 2013, 5:24 p.m.) Status -- This change has been mar

Re: Review Request 106581: Make KFileDialog remember settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- (Updated June 10, 2013, 7:22 p.m.) Review request for kdelibs and Andreas

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review34065 --- Ship it! Woohoo, much simpler. - David Faure On June 10, 20

Re: Review Request 106581: Make KFileDialog remember settings

> On Oct. 2, 2012, 10:55 a.m., David Faure wrote: > > kfile/kfilewidget.cpp, line 1875 > > > > > > OK, I was about to react against the move to a member variable > > configGroup (which basically means "accept() wi

Re: Review Request 110875: kcm_useraccount: support accountsservice

> On June 9, 2013, 2:30 p.m., David Edmundson wrote: > > kdepasswd/kcm/main.cpp, line 251 > > > > > > This might not be right. > > > > With an empty pixmap in the image you call > > uinterface->SetIco

Re: Review Request 110875: kcm_useraccount: support accountsservice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- (Updated June 10, 2013, 4:58 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/ --- (Updated June 10, 2013, 4:45 p.m.) Status -- This change has been mar

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

> On June 10, 2013, 8:26 a.m., David Faure wrote: > > I don't like the duplication very much (can't the old method call the V2 > > method, if the only difference is the return value, which the old method > > would then ignore?). > > > > Otherwise OK, as it's kind of temporary anyway. It just i

Re: Review Request 106581: Make KFileDialog remember settings

> On June 10, 2013, 4:41 p.m., Àlex Fiestas wrote: > > Forgot to say, beside that, ship it (tested and it works fine). - Àlex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#revie

Re: Review Request 106581: Make KFileDialog remember settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review34059 --- kfile/kfilewidget.cpp

Re: Review Request 106581: Make KFileDialog remember settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- (Updated June 10, 2013, 6:17 p.m.) Review request for kdelibs and Andreas

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/ --- (Updated June 10, 2013, 3:37 p.m.) Review request for kdelibs and David Fa

Re: K(Abstract)FileItemActionPlugin

2013/6/10, Frank Reininghaus : > It was indeed an *extremely* frustrating experience for me to find out > that code which had (to my knowledge) been written without any kind of > review could be installed and run on the machine of every Dolphin user > out there, and that the bug reports which were

Re: K(Abstract)FileItemActionPlugin

Hi Albert, thanks for the quick reply. 2013/6/9 Albert Astals Cid: > El Diumenge, 9 de juny de 2013, a les 09:22:10, Frank Reininghaus va escriure: >> Hi Albert, >> >> thanks for your comments. >> >> 2013/6/8 Albert Astals Cid: >> > El Divendres, 7 de juny de 2013, a les 17:40:29, Frank Reiningha

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/#review34032 --- Thanks for looking into this, Emmanuel! I'm looking forward to

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/#review34031 --- Ship it! - David Faure On June 10, 2013, 9:22 a.m., Emmanuel

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

> On June 10, 2013, 8:26 a.m., David Faure wrote: > > I don't like the duplication very much (can't the old method call the V2 > > method, if the only difference is the return value, which the old method > > would then ignore?). > > > > Otherwise OK, as it's kind of temporary anyway. It just i

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/ --- (Updated June 10, 2013, 9:22 a.m.) Review request for Dolphin, KDE Base Ap

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review34023 --- Looking at it further, this information is indeed already in th

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

> On June 10, 2013, 8:26 a.m., David Faure wrote: > > I don't like the duplication very much (can't the old method call the V2 > > method, if the only difference is the return value, which the old method > > would then ignore?). > > > > Otherwise OK, as it's kind of temporary anyway. It just i

Re: Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110924/#review34020 --- This review has been submitted with commit 3dafdf356b549c9f9cb

Re: Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110924/ --- (Updated June 10, 2013, 8:33 a.m.) Status -- This change has been mar

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/#review34017 --- I don't like the duplication very much (can't the old method ca

Re: Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110924/#review34015 --- Ship it! Patch looks good, but commit log is wrong, it says "t