Review Request 110625: Make it possible to disable KAbstractFileItemActionPlugins by default

2013-05-23 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110625/ --- Review request for kdelibs. Description --- Currently, all KAbstractF

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-05-23 Thread Ralf Jung
> On May 3, 2013, 8:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? Thomas fixed some existing issues which were uncovered by this patch, see https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no other issues are known. - Ralf

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-23 Thread Michel Ludwig
> On May 23, 2013, 9:16 a.m., Patrick von Reth wrote: > > Sorry for the missing feedback we already apply your patch locally and its > > already part of our release so please ship it. > > > > BIG THANKS Ok. As I haven't done any commits to kdelibs in a while, does anybody know what the curren

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-05-23 Thread Kevin Ottens
> On May 6, 2013, 11:49 a.m., Kevin Ottens wrote: > > My knowledge of the changes in the MMX/SSE landscape are slightly too > > limited for me to be 100% sure. But it looks like a fine patch. > > Patrick Spendrin wrote: > I just at that patch again, and I just realized that I changed the fl

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-23 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109246/#review33017 --- Ship it! Sorry for the missing feedback we already apply your

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-23 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109246/#review33016 --- Ship it! We have this fix already in the kdelibs-4.10.2 diff i

Re: Review Request 106300: add kimgio WebP image format plugin

2013-05-23 Thread Martin Koller
On Wednesday 22 May 2013 22:15:56 Albert Astals Cid wrote: > > > On May 18, 2013, 12:44 p.m., Commit Hook wrote: > > > This review has been submitted with commit > > > df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch > > > master. > > > > Christoph Feck wrote: > > Just no