Re: Review Request 103555: Fix for stale permissions information in properties dialog

2013-05-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- (Updated May 18, 2013, 11:20 p.m.) Review request for kdelibs and David Fa

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32763 --- This caused an unhandled switch warning in kdoctools/genshortcu

Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/ --- (Updated May 18, 2013, 10:05 p.m.) Status -- This change has been mar

Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
> On May 18, 2013, 7:50 p.m., David Faure wrote: > > Sure (I'm pretty sure this didn't even need reviewing :). > > > > I suppose the error was "no write permissions in the directory", it's the > > most likely one. > > (partition full would be the other one I can think of) Was about to post mor

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Ben Cooksley
> On May 18, 2013, 1:33 p.m., Albert Astals Cid wrote: > > ShipIt from anyone? Code looks fine from my point of view. I'm not the maintainer of kdeui though, so I won't give it a ship it for now. - Ben --- This is an automatically gener

Re: Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/#review32757 --- Ship it! Sure (I'm pretty sure this didn't even need reviewing

Review Request 110514: Me more precise about the error message in case KSaveFile fails.

2013-05-18 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110514/ --- Review request for kdelibs and David Faure. Description --- "Unable t

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-18 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109246/#review32742 --- any KDE Windows folks feel like taking a look at this one? -

Re: Review Request 109245: Remove duplicated calendar classes from calendar plasmoid

2013-05-18 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109245/#review32741 --- Ship it! please commit. remember to add the kdepimlibs 4.10 r

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32735 --- ShipIt from anyone? - Albert Astals Cid On May 9, 2013, 11:0

Re: Review Request 106300: add kimgio WebP image format plugin

2013-05-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ --- (Updated May 18, 2013, 12:44 p.m.) Status -- This change has been mar

Re: Review Request 106300: add kimgio WebP image format plugin

2013-05-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review32734 --- This review has been submitted with commit df845b06bc440fff5a4