Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/#review32545 --- I am not in favour of this patch for a couple of reasons. First

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- (Updated May 14, 2013, 10:35 p.m.) Review request for kde-workspace and Pl

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- (Updated May 14, 2013, 6:51 p.m.) Review request for kde-workspace. Desc

Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-14 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- Review request for kde-workspace. Description --- This patch adds a f

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32512 --- Ship it! Given the posted screenshot, setting a unique icon is

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32506 --- Ship it! Imo the patch looks good. So from my side it's a clea

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/ --- (Updated May 14, 2013, 4:31 p.m.) Review request for Dolphin, Kate and kde

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Aurélien Gâteau
> On May 7, 2013, 2:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function cal

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/ --- (Updated May 14, 2013, 1:53 p.m.) Review request for KDE Runtime. Change

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/ --- (Updated May 14, 2013, 1:52 p.m.) Review request for KDE Runtime. Descri

Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-14 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/ --- Review request for KDE Runtime. Description --- This adds a 'Insert q

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 14, 2013, 12:38 p.m.) Status -- This change has been mar

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32497 --- This review has been submitted with commit 8e023ae9e5051cb7b81

Re: Review Request 110421: Fix Konqueror's midnight commander profile

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ --- (Updated May 14, 2013, 12:36 p.m.) Status -- This change has been mar

Re: Review Request 110421: Fix Konqueror's midnight commander profile

2013-05-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/#review32495 --- This review has been submitted with commit 67d4ea943146a5e1d7f

Re: Review Request 110421: Fix Konqueror's midnight commander profile

2013-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/#review32492 --- Ship it! Ship It! - David Faure On May 14, 2013, 2:08 a.m.,