Re: Review Request 110421: Fix Konqueror's midnight commander profile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ --- (Updated May 14, 2013, 2:08 a.m.) Review request for KDE Base Apps and Dav

Review Request 110421: Fix Konqueror's midnight commander profile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ --- Review request for KDE Base Apps and David Faure. Description --- The

Re: Review Request 110420: Bugfix for bug #311364

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:56 a.m.) Status -- This change has been disc

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 14, 2013, 1:56 a.m.) Review request for KDE Base Apps, David

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

> On May 13, 2013, 10:07 p.m., Frank Reininghaus wrote: > > dolphin/src/dolphinremoveaction.cpp, line 28 > > > > > > Dolphin coding style: put the ':' just behind the closing ')' > > (separeated by a space), and p

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

> On May 13, 2013, 10:47 p.m., David Faure wrote: > > dolphin/src/dolphinpart.cpp, line 463 > > > > > > I don't understand the use of QPointer. > > Wouldn't it be enough to add m_removeAction = 0; after this l

Re: Review Request 110420: Bugfix for bug #311364

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:22 a.m.) Review request for kde-workspace and Pla

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32467 --- dolphin/src/dolphinpart.cpp

Re: Review Request 110277: Fix broken web shortcuts

> On May 13, 2013, 2:23 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 56e93089160557805f17863b848ac178bb8975a8 by Maarten De Meyer to branch > > master. @Maarten, maybe the part about fixing query URL's could also go to KDE/4.10 branch? - Hrvoje -

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

On segunda-feira, 13 de maio de 2013 19.05.54, Friedrich W. H. Kossebau wrote: > Am Montag, 13. Mai 2013, 10:06:59 schrieb Thiago Macieira: > > On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau > > wrote: > > > Interesting problem still: so any public symbol from a static lib

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32458 --- Thanks for the new patch! This is really very nice work, looks

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

Am Montag, 13. Mai 2013, 10:06:59 schrieb Thiago Macieira: > On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau wrote: > > Interesting problem still: so any public symbol from a static lib can > > potentially appear multiple times in a process, if coming with different > > lib

Re: R: Re: R: Re: R: Re: kde review kartesio

El Dissabte, 11 de maig de 2013, a les 14:37:06, LucaTringali va escriure: > Ooops: I thought I already corrected this problem, for some reason I did not > upload to git this correction. On my system the build goes fine also with > that line, but I decide to remove it because it can cause problems

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau wrote: > Interesting problem still: so any public symbol from a static lib can > potentially appear multiple times in a process, if coming with different > libs/modules, and then the first instance of that symbol shadows all

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

Hi Thiago, Am Sonntag, 12. Mai 2013, 14:21:10 schrieb Thiago Macieira: > On domingo, 12 de maio de 2013 22.47.35, Friedrich W. H. Kossebau wrote: > > + # Do not export QtUiTools internal symbols > > + set_target_properties(krossmoduleforms PROPERTIES LINK_FLAGS > > "-Wl,-- exclude-libs

Re: Review Request 110277: Fix broken web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/ --- (Updated May 13, 2013, 2:23 p.m.) Status -- This change has been mark

Re: Review Request 110277: Fix broken web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32448 --- This review has been submitted with commit 56e93089160557805f1

Re: Review Request 110277: Fix broken web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32447 --- This review has been submitted with commit c239f8eea6e3b634247

Re: Review Request 110277: Fix broken web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32446 --- This review has been submitted with commit 46ecc0fa5ea47594781

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 13, 2013, 1:02 p.m.) Review request for KDE Base Apps, David

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

> On May 13, 2013, 9:16 a.m., Frank Reininghaus wrote: > > dolphin/src/dolphinpart.cpp, line 463 > > > > > > I could not test it yet, but this looks like we have a dangling pointer > > m_removeAction after this a

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32428 --- Thanks for the refactoring. A few comments. dolphin/src/dolph

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32426 --- Thanks for the patch, this is greatly appreciated! I could not

R: Re: R: [kartesio] src: Fix some strings

Hi, there is a little misunderstanding: those two settings are not global settings. This is how it works: if you check BackProp, the neural network will be trained using back propagation. If you check GenAlg, the network will be trained with genetic algorithms. If you check both them, the networ

R: Re: R: Re: R: Re: kde review kartesio

Ooops: I thought I already corrected this problem, for some reason I did not upload to git this correction. On my system the build goes fine also with that line, but I decide to remove it because it can cause problems with other compiler configurations (on mine I just get a wrining, on other sys

R: Re: kde review kartesio

Yes, I also think adding new features now is not a good idea in this moment. This is the reason why the new version of Kartesio I uploaded to git (about 45 minutes ago) contains basically all the corrctions you suggested, but no new features. Luca Tringali >Messaggio originale >Da: ann

R: Re: R: Re: kde review kartesio

Hi, no, build.sh is not needed. Since I'm kinda lazy, I prepared a shell script to run the following commands: mkdir build cd build sudo make uninstall make clean rm CMakeCache.txt cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix` make sudo make install so I don't have to type all those eve

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 13, 2013, 8:10 a.m.) Review request for KDE Runtime, Casian A