Re: Review Request 110392: Do not overwrite directories inside a tar archive

2013-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- (Updated May 12, 2013, 1:44 a.m.) Status -- This change has been mark

Re: Review Request 110392: Do not overwrite directories inside a tar archive

2013-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/#review32367 --- This review has been submitted with commit fa9fa9ce0271e44117a

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-11 Thread Max Brazhnikov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110271/ --- (Updated May 11, 2013, 9:14 p.m.) Review request for kde-workspace. Chan

Re: Review Request 110392: Do not overwrite directories inside a tar archive

2013-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/#review32362 --- Ship it! Looks good, please commit. I just wrote a unittest fo

Review Request 110392: Do not overwrite directories inside a tar archive

2013-05-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110392/ --- Review request for kdelibs and David Faure. Description --- The attac

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-11 Thread Sune Vuorela
On 2013-05-11, Friedrich W. H. Kossebau wrote: > So, anyone with more clue than me WRT symbols from static libs and the > Bsymbolic-functions linker flag who could tell if that indeed should fix such > problems if code from the same static lib is arriving multiple times in the > same process vi

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 11, 2013, 8:05 p.m.) Review request for KDE Runtime and Casia

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 11, 2013, 7:47 p.m.) Review request for KDE Runtime and Casia

Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-11 Thread Friedrich W. H. Kossebau
Hi, tl;dr how to avoid crashes if libQtUiTools.a is linked multiple times into a process? You use at least one of kross, kjsembed, or plasma in your application/lib/module and possibly also directly libQtUiTools yourself? Then bugs.kde.org shows that chances are that you have seen crashes wit

Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-11 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- Review request for KDE Runtime. Description --- This patch fixes a pr

Re: new WebP image plugin (kimgio) and cmake question

2013-05-11 Thread Martin Koller
After a too long time, I try it again: On Saturday 01 September 2012 10:34:27 Martin Koller wrote: > Hi all, > > I've implemented a new kimgio plugin for the WebP image format. > read/write with variable quality is supported. > > - how can I add a new MIME Type for image/x-webp ? There was a c

Review Request 110388: Change default thumbnail cache directory

2013-05-11 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110388/ --- Review request for kdelibs. Description --- The freedesktop spec[0] h

Re: R: Re: R: Re: kde review kartesio

2013-05-11 Thread Anne-Marie Mahfouf
Hi, > > so I don't have to type all those every time I want to build Kartesio > again. > I'm not sure why you get that error, mainlybecause I don't know which > is the > instruction that gives that problem since I changed a lot the code in > these > hours. Try to download the latest git version a

Re: kde review kartesio

2013-05-11 Thread Anne-Marie Mahfouf
Hi, > >In general, you're mixing a lot of plain C / stdlib stuff into Qt > >code. Is there a reason for that? For example, in > >calculations.cpp:148 > >you take text from a text field, convert it to a byte array, convert > >it to a char* and then pass it to a function. Why not just pass the > >Q

R: Re: kde review kartesio

2013-05-11 Thread LucaTringali
Hello everybody, just wanted to tell you that I made some fixes to the code, based on your suggestions: *comments in header files *deleted some unseful string *check routine to avoid that a dangerous string like "**" or similar is used for the function *add where to download zorbaneural in cmake

Re: R: Re: kde review kartesio

2013-05-11 Thread Anne-Marie Mahfouf
Hi, > Hi, > actually I have not prepared any binary package. Anyway, you can > install > Kartesio downloading the source code from the git repo > (https://projects.kde. > org/projects/kdereview/kartesio), installing the library > libzorbaneural (https: > //www.gitorious.org/zorbaneural/zorbaneura

Re: Re: kde review kartesio

2013-05-11 Thread LucaTringali
Hi, I'll answer point to point: >Messaggio originale >Hey! > >A good thing, I think such a tool could be useful to me too (and I >know a lot of other people to whom it might be useful). Here's what I >noticed from a quick look (some has been said already I think): > >* You probably should

R: Re: kde review kartesio

2013-05-11 Thread LucaTringali
Hi, actually I have not prepared any binary package. Anyway, you can install Kartesio downloading the source code from the git repo (https://projects.kde. org/projects/kdereview/kartesio), installing the library libzorbaneural (https: //www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary

R: Re: kde review kartesio

2013-05-11 Thread LucaTringali
Hello, libzorbaneural can be found here: https://www.gitorious.org/zorbaneural/zorbaneural/trees/master Here are also some packages for the stable version (deb and rpm): https://www.gitorious.org/zorbaneural/zorbaneural/trees/master/binary- packages/libzorbaneural-0.1 Once you have installed it, t

Re: Re: kde review kartesio

2013-05-11 Thread LucaTringali
Yes, Kartesio is used to calculate fitting curves for experimental points: I, as a chemistry student, already used it for some laboratory reports. Actually, there is no other program like this in KDE: obiously you could obtain something similar with RKward, but this one is too much complex for f