Re: Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330

2013-05-08 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/ --- (Updated May 8, 2013, 11:16 p.m.) Review request for KDE Runtime and Haral

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-08 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 8, 2013, 11:12 p.m.) Review request for KDE Runtime and Haral

Re: Requesting freeze exception for JtG

2013-05-08 Thread Lydia Pintscher
On Thu, May 9, 2013 at 12:23 AM, Albert Astals Cid wrote: > Personally I don't think it looks nice in our menus, but i'm not the kdeui > maintainer. I'll let people with an opinion discuss if we want it in or not. > > Meanwhile i've done the grunt work. > > https://git.reviewboard.kde.org/r/110367

Re: Requesting freeze exception for JtG

2013-05-08 Thread Albert Astals Cid
El Dimarts, 7 de maig de 2013, a les 19:10:15, Lydia Pintscher va escriure: > On Tue, May 7, 2013 at 12:41 AM, Albert Astals Cid wrote: > > I guess now that we have a "not totally frozen" kdelibs you could just > > commit it to master and merge to frameworks and be done with it. > > > > Obviously

Review Request 110367: Add JoinTheGame menu entry

2013-05-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/ --- Review request for kdelibs. Description --- Patch by Pau ages ago, Ly

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-08 Thread Harald Sitter
> On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: > > I'd like to enable this by default, most people I know from the community > > thinks alike. > > > > Code wise it makes sense. > > Eike Hein wrote: > For clarification: Do you mean enable (= prompt, already the default) or > disable (be

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-08 Thread Volker Krause
> On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: > > I'd like to enable this by default, most people I know from the community > > thinks alike. > > > > Code wise it makes sense. > > Eike Hein wrote: > For clarification: Do you mean enable (= prompt, already the default) or > disable (be

Re: Review Request 110090: Clean up kickoff from stale bits

2013-05-08 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110090/#review32262 --- Ship it! Thanks for the cleanup. You might also want to remove

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-08 Thread Rolf Eike Beer
Am Dienstag, 7. Mai 2013, 22:21:46 schrieb Àlex Fiestas: > Would be nice to have some kind of unittests on this, that will make a > different with the current implementation (which afaik it has none) Even better would be to have them first to prove that nothing changed afterwards ;) Eike signatu

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-08 Thread Àlex Fiestas
> On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: > > I'd like to enable this by default, most people I know from the community > > thinks alike. > > > > Code wise it makes sense. > > Eike Hein wrote: > For clarification: Do you mean enable (= prompt, already the default) or > disable (be

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-08 Thread Eike Hein
> On May 7, 2013, 8:15 p.m., Àlex Fiestas wrote: > > I'd like to enable this by default, most people I know from the community > > thinks alike. > > > > Code wise it makes sense. For clarification: Do you mean enable (= prompt, already the default) or disable (be silent)? - Eike -