Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-05-07 Thread Àlex Fiestas
Would be nice to have some kind of unittests on this, that will make a different with the current implementation (which afaik it has none) On Mon, May 6, 2013 at 4:14 PM, Martin Briza wrote: > Well, as I said last week, I started working on it. > First few commits are in branch mbriza/kdisplaym

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

2013-05-07 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32224 --- I'd like to enable this by default, most people I know from the

Re: NepomukCore - Do not merge KDE/4.10 into master

2013-05-07 Thread Rolf Eike Beer
Am Dienstag, 7. Mai 2013, 00:30:25 schrieb Albert Astals Cid: > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va escriure: > > Hey everyone > > > > As you might have heard there was a fiasco in the nepomuk-core repository > > where the 'master' branch was accidentally merged into K

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Dominik Haumann
> On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function ca

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Dominik Haumann
> On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function ca

Re: KF5: Let's get KDEUI down

2013-05-07 Thread Kevin Ottens
On Tuesday 07 May 2013 19:26:01 Kevin Ottens wrote: > On Tuesday 07 May 2013 19:13:03 Kevin Ottens wrote: > > We also plan to hold regular meetings to share efforts and progress. They > > will happen on #kde-devel every Tuesday at 4pm. > > Since I got the question already, the timezone will be UTC

Re: KF5: Let's get KDEUI down

2013-05-07 Thread Kevin Ottens
On Tuesday 07 May 2013 19:13:03 Kevin Ottens wrote: > We also plan to hold regular meetings to share efforts and progress. They > will happen on #kde-devel every Tuesday at 4pm. Since I got the question already, the timezone will be UTC+1 AKA "the timezone I live in". :-) Regards. -- Kévin Otte

KF5: Let's get KDEUI down

2013-05-07 Thread Kevin Ottens
Hello all, I didn't make noise about KDE Frameworks for a while now, and to the outside it could look like it wasn't making progress. Let me assure you: this is not the truth. Admittedly, I decided to take a risk a few months ago... I stopped communicating or reaching toward people to get more con

Re: Requesting freeze exception for JtG

2013-05-07 Thread Lydia Pintscher
On Tue, May 7, 2013 at 12:41 AM, Albert Astals Cid wrote: > I guess now that we have a "not totally frozen" kdelibs you could just commit > it to master and merge to frameworks and be done with it. > > Obviously needs to happen before the Soft/Hard Freeze. Is there anyone willing and able to do t

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Thomas Lübking
> On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function ca

Re: Requesting freeze exception for JtG

2013-05-07 Thread Albert Astals Cid
El Dimarts, 7 de maig de 2013, a les 13:26:51, Aaron J. Seigo va escriure: > On Tuesday, May 7, 2013 00:41:50 Albert Astals Cid wrote: > > I guess now that we have a "not totally frozen" kdelibs you could > > just > > > commit it to master and merge to frameworks and be done with > > it. > > co

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Aurélien Gâteau
> On May 7, 2013, 2:50 p.m., Dominik Haumann wrote: > > The patch itself is fine and most likely does not introduce regressions in > > terms of misbehavior. > > > > Still, is never showing an icon the way to go? Another way to work around > > this by default would be an additional function cal

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 4:14 p.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 2:25 p.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32194 --- The patch itself is fine and most likely does not introduce reg

Re: Requesting freeze exception for JtG

2013-05-07 Thread Aaron J. Seigo
On Tuesday, May 7, 2013 00:41:50 Albert Astals Cid wrote: > I guess now that we have a "not totally frozen" kdelibs you could just > commit it to master and merge to frameworks and be done with it. commit it to the 4.10 branch; dfaure handles merging to master. -- Aaron J. Seigo signature.as

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Thomas Lübking
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32184 --- The solution is intentionally "shy", I really don't want to fan

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 10:04 a.m.) Review request for kdelibs and Thiago Ma

Re: Review Request 110084: Make ftp error messages prettier

2013-05-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110084/ --- (Updated May 7, 2013, 7:48 a.m.) Review request for kdelibs and David Faur