Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/ --- (Updated May 6, 2013, 11:14 p.m.) Status -- This change has been mark

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/#review32175 --- This review has been submitted with commit 79f16dbaae1d9a5200e

Re: NepomukCore - Do not merge KDE/4.10 into master

El Dimarts, 7 de maig de 2013, a les 00:54:20, Albert Astals Cid va escriure: > El Dilluns, 6 de maig de 2013, a les 19:49:13, Nicolás Alvarez va escriure: > > 2013/5/6 Albert Astals Cid > > > > > El Dilluns, 6 de maig de 2013, a les 19:37:15, Nicolás Alvarez va > > escriure: > > > > 2013/5/6 Al

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/#review32174 --- Ship it! I haven't reviewed the binary files, but the rest LGT

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/ --- (Updated May 6, 2013, 11:04 p.m.) Review request for kde-workspace and Fre

Re: NepomukCore - Do not merge KDE/4.10 into master

El Dilluns, 6 de maig de 2013, a les 19:49:13, Nicolás Alvarez va escriure: > 2013/5/6 Albert Astals Cid > > > El Dilluns, 6 de maig de 2013, a les 19:37:15, Nicolás Alvarez va escriure: > > > 2013/5/6 Albert Astals Cid > > > > > > > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Hand

Re: NepomukCore - Do not merge KDE/4.10 into master

2013/5/6 Albert Astals Cid > El Dilluns, 6 de maig de 2013, a les 19:37:15, Nicolás Alvarez va escriure: > > 2013/5/6 Albert Astals Cid > > > > > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va > escriure: > > > > Hey everyone > > > > > > > > As you might have heard there was a

Re: Requesting freeze exception for JtG

El Diumenge, 28 d'abril de 2013, a les 14:05:45, Lydia Pintscher va escriure: > On Tue, Nov 22, 2011 at 2:51 AM, Pau Garcia i Quiles > > wrote: > > Hi, > > > > Last weekend we had the KDE eV Sprint at Berlin. > > > > For various reasons, financial mainly, it was clear we need to raise > > visib

Re: NepomukCore - Do not merge KDE/4.10 into master

El Dilluns, 6 de maig de 2013, a les 19:37:15, Nicolás Alvarez va escriure: > 2013/5/6 Albert Astals Cid > > > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va escriure: > > > Hey everyone > > > > > > As you might have heard there was a fiasco in the nepomuk-core > > > repository

Re: NepomukCore - Do not merge KDE/4.10 into master

2013/5/6 Albert Astals Cid > El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va escriure: > > Hey everyone > > > > As you might have heard there was a fiasco in the nepomuk-core repository > > where the 'master' branch was accidentally merged into KDE/4.10. Since > then > > the syst

Re: NepomukCore - Do not merge KDE/4.10 into master

El Dissabte, 4 de maig de 2013, a les 14:01:45, Vishesh Handa va escriure: > Hey everyone > > As you might have heard there was a fiasco in the nepomuk-core repository > where the 'master' branch was accidentally merged into KDE/4.10. Since then > the system admins had to do a hard reset to v4.10.

Re: Review Request 110328: Add config option to silently create initial password-less wallet

On Monday, May 06, 2013 19:11:19 Eike Hein wrote: > > How does KWallet encrypt if no password has been set? > > About as badly as one would expect. It does still generate a hash which > it uses for encryption. What kwalletd does is try whether it can open a > wallet with an empty password first (t

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/#review32170 --- kcontrol/input/xcursor/xcursortheme.cpp

Re: Review Request 110327: KMessageWidget: Remove decoration icon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/ --- (Updated May 6, 2013, 10:59 p.m.) Review request for Dolphin, Kate and kde

Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339/ --- Review request for kde-workspace and Fredrik Höglund. Description ---

Re: Review Request 110327: KMessageWidget: Remove decoration icon

> On May 6, 2013, 8:45 p.m., Frank Reininghaus wrote: > > kdeui/widgets/kmessagewidget.cpp, line 253 > > > > > > I guess you can remove the variable 'icon' from this function now, > > right? Indeed. Removing it.

Re: Review Request 110327: KMessageWidget: Remove decoration icon

> On May 6, 2013, 9:32 p.m., Thomas Lübking wrote: > > Semi-OT (sorry) - what makes this thing appear "on top" of things (below > > the toolbar) - and why? > > In a NW gravity world, this means the UI is shifted downwards "under the > > users fingers" (no matter where you are, the poaint where

Re: Review Request 110327: KMessageWidget: Remove decoration icon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32154 --- Semi-OT (sorry) - what makes this thing appear "on top" of thin

Re: Review Request 110327: KMessageWidget: Remove decoration icon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32149 --- Looks very reasonable from my point of view, thanks! And yes,

Re: Review Request 110327: KMessageWidget: Remove decoration icon

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32146 --- I think your patch will fix the bug 304775. ;) Bug 304775 - Mu

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 5:28 p.m.) Review request for KDE Runtime and Harald

Re: Review Request 110328: Add config option to silently create initial password-less wallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/ --- (Updated May 6, 2013, 5:25 p.m.) Review request for KDE Runtime and Harald

Re: Review Request 110328: Add config option to silently create initial password-less wallet

> > How does KWallet encrypt if no password has been set? > About as badly as one would expect. It does still generate a hash which it uses for encryption. What kwalletd does is try whether it can open a wallet with an empty password first (thus generating the same hash) and ask for one to be ente

Re: Review Request 110328: Add config option to silently create initial password-less wallet

> On May 6, 2013, 4:40 p.m., Lamarque Souza wrote: > > kwalletd/kwalletd.h, line 226 > > > > > > Why split this feature into three different review requests? One of > > your requests [2] is just one line change a

Re: Review Request 110328: Add config option to silently create initial password-less wallet

> On May 6, 2013, 4:40 p.m., Lamarque Souza wrote: > > kwalletd/kwalletd.h, line 226 > > > > > > Why split this feature into three different review requests? One of > > your requests [2] is just one line change a

Re: Review Request 110328: Add config option to silently create initial password-less wallet

He probably only thought about the extra QString() which Pino just prove it's useless, I was with lamarque because of the Krazy check but this one is indeed crazy :P Maybe QLatin1String("") can be better than just "" in this case 2013/5/6 Eike Hein : > >> >> $ grep -A1 QString::clear /usr/include/

Re: Review Request 110328: Add config option to silently create initial password-less wallet

> > $ grep -A1 QString::clear /usr/include/qt4/QtCore/qstring.h > inline void QString::clear() > { if (!isNull()) *this = QString(); } > Fun - the "and makes it empty" part in the QString docs sure makes it sound like it's going to make it non-null, I guess that's what Lamarque thought. OK, so b

Re: libs/kworkspace/kdisplaymanager.cpp mess

Well, as I said last week, I started working on it. First few commits are in branch mbriza/kdisplaymanager-split. Currently, PLEASE, don't judge me for the KDMBackendPrivate class stuff. :) I have just cut that out of KDisplayManager, not really knowing what to do with it further. I'll try to

Re: Review Request 110328: Add config option to silently create initial password-less wallet

Alle lunedì 6 maggio 2013, Lamarque Souza ha scritto: > password is a QString, right? Then you should use > password.clear() here instead of assigning an empty QString. That > avoids creating a temporary QString. $ grep -A1 QString::clear /usr/include/qt4/QtCore/qstring.h inline void QString:

Re: Review Request 110328: Add config option to silently create initial password-less wallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/ --- (Updated May 6, 2013, 4:48 p.m.) Review request for KDE Runtime and Harald

Re: Review Request 110328: Add config option to silently create initial password-less wallet

On segunda-feira, 6 de maio de 2013 16.01.27, Eike Hein wrote: > It's a change desired by downstream consumers Kubuntu and Netrunner, and > perhaps others, and recreates a modification they used to carry for KDE 3. > Their goal is to make KWallet mostly invisible to the user during routine > operat

Re: Review Request 110328: Add config option to silently create initial password-less wallet

> On May 6, 2013, 4:40 p.m., Lamarque Souza wrote: > > kwalletd/kwalletd.h, line 226 > > > > > > Why split this feature into three different review requests? One of > > your requests [2] is just one line change a

Re: Review Request 110328: Add config option to silently create initial password-less wallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/#review32142 --- kwalletd/kwalletd.h

Re: Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- (Updated May 6, 2013, 4:17 p.m.) Review request for KDE Runtime and Harald

Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/ --- Review request for KDE Runtime and Harald Sitter. Description --- Thi

Review Request 110330: Make "Prompt on access" kwalletd setting apply in more situations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ --- Review request for KDE Runtime and Harald Sitter. Description --- kwa

Re: Review Request 110328: Add config option to silently create initial password-less wallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/ --- (Updated May 6, 2013, 4:01 p.m.) Review request for KDE Runtime and Harald

Review Request 110328: Add config option to silently create initial password-less wallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/ --- Review request for KDE Runtime and Harald Sitter. Description --- Thi

Re: Review Request 109551: port KPtyProcess to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review32130 --- Martin, any news about that patch? Or we still have no clue why

Re: Review Request 109538: port KFileMetaDataReader to QProcess

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/ --- (Updated May 6, 2013, 11:57 a.m.) Status -- This change has been disc

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review32127 --- Ship it! My knowledge of the changes in the MMX/SSE landscape

Review Request 110277: Fix broken web shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/ --- Review request for KDE Runtime. Description --- I have gone through a

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

On Saturday, May 4, 2013 22:21:07 you wrote: > approach would have had no technical advantage other than working around > the pointless freeze. i understand the freeze is pointless to you. it is not pointless to others. > (Quite the opposite, the plugin approach that was > suggested would have in