Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32111 --- Thanks for taking care of this! Just a few comments. dolphin/

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32093 --- I don't like it. There's a reason why I removed the equivalent

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110313/ --- (Updated May 5, 2013, 2:32 p.m.) Status -- This change has been marke

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110313/#review32088 --- This review has been submitted with commit b45d3208240e3fb0b03

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 5, 2013, 1:53 p.m.) Review request for KDE Base Apps, David F

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 1:31 p.m.) Status -- This change has been marke

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32081 --- This review has been submitted with commit c44df47be1ddf69df38

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32080 --- Ship it! Ship It! - Oswald Buddenhagen On May 5, 2013, 12:0

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110313/#review32079 --- Ship it! Ship It! - Dawit Alemayehu On May 4, 2013, 10:50 p

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Dawit Alemayehu
> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote: > > kurifilter-plugins/ikws/ikwsopts.cpp, line 412 > > > > > > What is the point of using a QPointer when the parent is set to NULL ? > > Maarten De Meyer wrote

Re: Review Request 110313: Some KUrifilter-plugin Krazy fixes

2013-05-05 Thread Maarten De Meyer
> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote: > > kurifilter-plugins/ikws/ikwsopts.cpp, line 107 > > > > > > what exactly is ? Is this i18n specific keyword ? Yes it is il8n semantic markup. is a Line bre

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
> On May 5, 2013, 11:41 a.m., Oswald Buddenhagen wrote: > > kdm/kfrontend/genkdmconf.c, line 2112 > > > > > > and now you ignored the warning from the compiler. ;) Apologies, my C/C++ knowledge is quite rusty

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 12:02 p.m.) Review request for kde-workspace, Luboš

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32067 --- kdm/kfrontend/genkdmconf.c

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 11:37 a.m.) Review request for kde-workspace, Luboš

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32066 --- kdm/kfrontend/genkdmconf.c

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-05 Thread Max Brazhnikov
> > Ok, here's a patch for GetInfo_ReadfromPipe only: > > http://people.freebsd.org/~makc/patches/read_from_pipe.diff > > Looks good to me (although I have not tested it). Small note: there is > a contructor of QStringList taking a QString so if you have a list with > only one item you don't nee

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-05 Thread Max Brazhnikov
> Am 02.05.2013 15:49, schrieb Max Brazhnikov: > > > Use libusb-1 to query info about usb devices in kinfocenter. > > Remove *BSD specific code: it doesn't work on all supported FreeBSD > > versions. In principle it can be saved for NetBSD, but NetBSD could > > use libusb-1, thus drop it for simpl

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 11:22 a.m.) Review request for kde-workspace, Luboš

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
> On May 5, 2013, 11:01 a.m., Oswald Buddenhagen wrote: > > kdm/kfrontend/genkdmconf.c, line 2112 > > > > > > i wonder whether this condition is actually useful. i originally added > > it because some *BSDs (iir

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32063 --- kdm/kfrontend/genkdmconf.c

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 10:53 a.m.) Review request for kde-workspace, Luboš

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote: > > useradd also exists on debian ("useradd is a low level utility for adding > > users. On Debian, administrators should usually use adduser(8) instead."), > > so in principle the paths can be unified. > > > > however, when i was trying

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Thomas Lübking
> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote: > > useradd also exists on debian ("useradd is a low level utility for adding > > users. On Debian, administrators should usually use adduser(8) instead."), > > so in principle the paths can be unified. > > > > however, when i was trying

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
> On May 5, 2013, 10:09 a.m., Oswald Buddenhagen wrote: > > useradd also exists on debian ("useradd is a low level utility for adding > > users. On Debian, administrators should usually use adduser(8) instead."), > > so in principle the paths can be unified. > > > > however, when i was trying

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/#review32057 --- useradd also exists on debian ("useradd is a low level utility

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

2013-05-05 Thread Alexander Neundorf
On Sunday 05 May 2013, Martin Graesslin wrote: ... > As I already wrote in my last mail to this thread: yes everybody knows your > opinion of how kdelibs freeze should be handled. Repeating it in every > single thread which might even be slightly related to the freeze, won't > change anything. All

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32055 --- this is kinda getting old ... just two links to discussions i w

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 5, 2013, 8:13 a.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and group properly

2013-05-05 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110315/ --- (Updated May 5, 2013, 8:04 a.m.) Review request for kde-workspace, Luboš L

Re: Plasma Workspaces 4.11: the last feature release in the 4.xseries for kde-workspace

2013-05-05 Thread Martin Graesslin
On Saturday 04 May 2013 22:34:04 Kevin Kofler wrote: > On Friday 03 May 2013 at 17:04:44, Matthias Klumpp wrote: > > @Kevin: I am only remotely following this issue, but as PackageKit > > developer, I would of course like to see our project in Plasma > > Workspaces as soon as possible. But I don't