Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31926 --- CMakeLists.txt

Re: Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

On Thursday 02 May 2013 22:22:36 Kevin Kofler wrote: > On Wednesday 01 May 2013 at 09:41:15, Andriy Rysin wrote: > > If the feature freeze for 4.11 is May 22 and there is no more feature > > releases for branch 4.x, where all those features from GSoC go? > > Probably the same as my libplasma Packa

Re: libs/kworkspace/kdisplaymanager.cpp mess

On Thu, 02 May 2013 13:12:55 +0200, Martin Briza wrote: On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory wil

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

On Wednesday 01 May 2013 at 09:41:15, Andriy Rysin wrote: > If the feature freeze for 4.11 is May 22 and there is no more feature > releases for branch 4.x, where all those features from GSoC go? Probably the same as my libplasma PackageKit integration from GSoC 2011: in the digital nirvana and/o

Re: Review Request 110259: Fix kurifiltertest to use the new google query

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110259/ --- (Updated May 2, 2013, 7:31 p.m.) Status -- This change has been marke

Re: Review Request 110259: Fix kurifiltertest to use the new google query

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110259/#review31912 --- This review has been submitted with commit 856b89dc43b8551c846

Re: Proposed web shortcut changes

On Monday 29 April 2013 23:40:31 Maarten De Meyer wrote: > If people agree with the proposed changes The proposed changes seem fine to me. Thanks a lot for going through that! > is it ok to put it in one big patch on reviewboard? >From my point of view, yes. > Some shortcuts offer revenue shar

Re: Review Request 110259: Fix kurifiltertest to use the new google query

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110259/#review31904 --- Ship it! Ship It! - David Faure On May 1, 2013, 6:41 p.m.,

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

Am 02.05.2013 15:12, schrieb Max Brazhnikov: On Wed, 01 May 2013 14:44:39 +0200 Rolf Eike Beer wrote: On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: kinfocenter/Modules/base/info_fbsd.cpp, line 136 > > Why

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

Am 02.05.2013 15:49, schrieb Max Brazhnikov: Use libusb-1 to query info about usb devices in kinfocenter. Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification. Remove

Re: Proposed web shortcut changes

On Mon, 29 Apr 2013, Maarten De Meyer wrote: Qt: http://qt-project.org/doc/search/qt-5.0?search=\\{@} Do we need an extra qt4 documentation shortcut? (Qt3 is removed) I'd say yes. Boud

Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110271/ --- Review request for kde-workspace. Description --- Use libusb-1 to que

Re: libs/kworkspace/kdisplaymanager.cpp mess

On Tue, 30 Apr 2013 17:35:01 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: - The KDisplayManager class is used only on a few places so replacing its constructions with calls to the factory will be easy. oh, btw.. the LightDM code there is also shar

Re: libs/kworkspace/kdisplaymanager.cpp mess

On Tue, 30 Apr 2013 17:33:57 +0200, Aaron J. Seigo wrote: On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: I would leave creating the CK module to somebody who is experienced with how exactly the whole system works and knows if it is safe. if it is a refactor, this should be a matter

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

On Wed, May 1, 2013 at 3:15 PM, Aaron J. Seigo wrote: > ** > > > > For Plasma Workspaces 2, our goal is to have a user ready release in Q2 > 2013. This release will not necessarily be tied to the release schedule of > Frameworks 5, nor does it impact in any way application development which > sho

Proposed web shortcut changes

Hi everybody, I have gone through and and tested most (if not all) of the default web shortcuts in kde-runtime. These are my proposed changes and notes to fix the broken ones. Warning: long mail! 1. Most of the shortcuts that were no longer working only needed an updated url. Amg: http://www.all

Re: Review Request 110266: Cleanp Places Panel context menu

> On May 2, 2013, 10:15 a.m., Heiko Tietze wrote: > > Of course the changes do improve the menu and I believe your proposal would > > be helpful. > > > > But I would like to discuss the following points: > > > > * Adding a header to menus is not commonly used. And I'm not sure why I > > need

Re: Review Request 110266: Cleanp Places Panel context menu

Hi, On Thursday, May 02, 2013 08:05:48 Kai Uwe Broulik wrote: > This patch cleans up the places panel context menu by: > - Removing the term "Entry" and the entry name in every single item. To > still have easy context, I added a menu title instead. - General actions > such as "Show all" and "Add

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

On Wed, 01 May 2013 14:44:39 +0200 Rolf Eike Beer wrote: > > > On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: > > > > kinfocenter/Modules/base/info_fbsd.cpp, line 136 > > > > > > > ine136>> > > > > > Why not just u

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

Hi Todd, On Wednesday, May 01, 2013 15:42:10 Todd wrote: > On Wed, May 1, 2013 at 3:15 PM, Aaron J. Seigo wrote: > > For Plasma Workspaces 2, our goal is to have a user ready release in Q2 > 2013. This release will not necessarily be tied to the release schedule of > Frameworks 5, nor does it i

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

> On May 1, 2013, 9:03 p.m., Parker Coates wrote: > > Since KRandomSequence is a class for generating a predictable random > > sequence, is it not possible that this change would break applications that > > relied on the code below producing a consistent result between kdelibs > > releases? >

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

> On May 1, 2013, 9:03 p.m., Parker Coates wrote: > > Since KRandomSequence is a class for generating a predictable random > > sequence, is it not possible that this change would break applications that > > relied on the code below producing a consistent result between kdelibs > > releases? >

Re: Review Request 110247: New web shortcut. Copy link from clipboard

> On May 2, 2013, 9:30 a.m., David Faure wrote: > > kurifilter-plugins/ikws/searchproviderdlg.cpp, line 68 > > > > > > The argument is not necessary, Clipboard is the default value. Fixed both problems locally. Th

Re: Review Request 110247: New web shortcut. Copy link from clipboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/ --- (Updated May 2, 2013, 11:53 a.m.) Status -- This change has been mark

Re: Review Request 110247: New web shortcut. Copy link from clipboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/#review31884 --- This review has been submitted with commit 53a352fb4f8b9604eb4

Re: Review Request 110266: Cleanp Places Panel context menu

> On May 2, 2013, 10:15 a.m., Heiko Tietze wrote: > > Of course the changes do improve the menu and I believe your proposal would > > be helpful. > > > > But I would like to discuss the following points: > > > > * Adding a header to menus is not commonly used. And I'm not sure why I > > need

Re: Review Request 110266: Cleanp Places Panel context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110266/#review31877 --- Of course the changes do improve the menu and I believe your pr

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

> On May 1, 2013, 9:03 p.m., Parker Coates wrote: > > Since KRandomSequence is a class for generating a predictable random > > sequence, is it not possible that this change would break applications that > > relied on the code below producing a consistent result between kdelibs > > releases? >

Re: Review Request 110247: New web shortcut. Copy link from clipboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/#review31875 --- Ship it! Looks good, just two minor things to fix, then commit

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 2, 2013, 8:49 a.m., Christophe Giboudeaux wrote: > > LibKFbAPI-KDEPIMConfig.cmake.in, line 24 > > > > > > CMake will stop at this point. > > > > Exported targets can only be loaded once. > >

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31872 --- LibKFbAPI-KDEPIMConfig.cmake.in

Re: Review Request 110266: Cleanp Places Panel context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110266/#review31871 --- kfile/kfileplacesmodel.cpp

Review Request 110266: Cleanp Places Panel context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110266/ --- Review request for kdelibs, KDE Usability, Aaron J. Seigo, and Frank Reinin

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31870 --- Ping? - Martin Klapetek On April 29, 2013, 11:18 a.m., Marti