Re: Review Request 109828: Separate configuration from history in Klipper's popup menu

2013-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109828/#review31820 --- klipper/klipper.h

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31809 --- Ship it! Ship It! - Aaron J. Seigo On April 30, 2013, 9:04

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-30 Thread Aaron J. Seigo
On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: > - The KDisplayManager class is used only on a few places so replacing its > constructions with calls to the factory will be easy. oh, btw.. the LightDM code there is also shared by SDDM. calling it "LightDM" is a bit of a misnomer now

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-30 Thread Aaron J. Seigo
On Thursday, April 25, 2013 15:11:25 Martin Briza wrote: > I would leave creating the CK module to somebody who is experienced with > how exactly the whole system works and knows if it is safe. if it is a refactor, this should be a matter of moving the CK code as-is into a new file. if the refact

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
> On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: > > cmake/modules/FindLibdevinfo.cmake, lines 8-11 > > > > > > Why is this necessary at all? If you don't have a strong reason for it > > just drop it. result

Re: Review Request 110090: Clean up kickoff from stale bits

2013-04-30 Thread Max Brazhnikov
Hi, Can anybody review this patch? Thanks, Max On Fri, 19 Apr 2013 22:13:46 + Max Brazhnikov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110090/ >

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110091/ --- (Updated April 30, 2013, 11:50 a.m.) Review request for kde-workspace. D

Review Request 110247: New web shortcut. Copy link from clipboard

2013-04-30 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/ --- Review request for KDE Runtime. Description --- When making a new web

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-30 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 30, 2013, 12:04 p.m.) Review request for kdelibs, Aaron J.