Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/ --- (Updated April 28, 2013, 8:22 p.m.) Status -- This change has been ma

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/#review31711 --- This review has been submitted with commit 4f2ecbabfa5bec07985

Re: Review Request 104052: KImageCache optimization

2013-04-28 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated April 28, 2013, 5:49 p.m.) Status -- This change has been di

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread Frank Reininghaus
> On April 28, 2013, 2:55 p.m., David Faure wrote: > > You were right about the assert, I was off by a "!" in my head. > > > > This patch looks good - except that the comment is buggy :) Thanks David, there is indeed a typo in the comment ;-) I'll fix that and push the patch to KDE/4.10. - F

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/#review31698 --- You were right about the assert, I was off by a "!" in my head.

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/ --- (Updated April 28, 2013, 1:28 p.m.) Review request for kdelibs, David Faur

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread Frank Reininghaus
> On April 28, 2013, 8:26 a.m., David Faure wrote: > > kdecore/io/kmountpoint.cpp, line 478 > > > > > > The function would be shorter to write this way: > > > > > > if (parent == child) { > >

Re: Requesting freeze exception for JtG

2013-04-28 Thread Lydia Pintscher
On Tue, Nov 22, 2011 at 2:51 AM, Pau Garcia i Quiles wrote: > Hi, > > Last weekend we had the KDE eV Sprint at Berlin. > > For various reasons, financial mainly, it was clear we need to raise > visibility of the Join the Game campaign in order to get more users to > sign up. One of the decisions t

Re: Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/#review31692 --- kdecore/io/kmountpoint.cpp