Re: Review Request 106300: add kimgio WebP image format plugin

2013-04-27 Thread Martin Koller
> On April 10, 2013, 10:52 p.m., Albert Astals Cid wrote: > > Martin, can you clarify Allan's comments? done - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review30892 -

Review Request 110225: Fix KMountPoint::List::findByPath(const QString&): /books is not a sub-path of /book

2013-04-27 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/ --- Review request for kdelibs, David Faure and Jekyll Wu. Description ---

Re: Review Request 106300: add kimgio WebP image format plugin

2013-04-27 Thread Martin Koller
> On Sept. 10, 2012, 10:48 p.m., Allan Sandfeld Jensen wrote: > > kimgio/webp.cpp, lines 67-73 > > > > > > This seems needlessly explicit, why not just copy the whole block into > > QImage? QImage::scanLine docu sa

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 12:04 p.m.) Review request for kdelibs, Aaron J.

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Ömer Fadıl Usta
> On April 27, 2013, 10:40 a.m., Thomas Lübking wrote: > > plasma/private/dialogshadows.cpp, line 371 > > > > > > this looks slightly like a recursion? > > (i think void DialogShadows::Private::freeX11Pixmaps(

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Thomas Lübking
> On April 27, 2013, 7:40 a.m., Thomas Lübking wrote: > > plasma/private/dialogshadows.cpp, line 371 > > > > > > this looks slightly like a recursion? > > (i think void DialogShadows::Private::freeX11Pixmaps()

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Ömer Fadıl Usta
> On April 27, 2013, 10:40 a.m., Thomas Lübking wrote: > > that part of patch comes from here i think : https://git.reviewboard.kde.org/r/110029/ ( it was marked as ship it ) [i will wait until it commits than i will send my part. But if you think there is a strange behavior on that clearPixma

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 11:01 a.m.) Review request for kdelibs, Aaron J.

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-27 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31652 --- plasma/private/dialogshadows.cpp