Re: Review Request 110110: Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal

2013-04-22 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110110/ --- (Updated April 23, 2013, 8:08 a.m.) Review request for kdelibs. Changes

Re: First draft of a KHumanDateTimeParser class

2013-04-22 Thread Albert Astals Cid
El Divendres, 19 d'abril de 2013, a les 08:21:05, David Faure va escriure: > On Tuesday 16 April 2013 15:05:51 Denis Steckelmacher wrote: > > if we are a Monday, next Tuesday is tomorrow, not in > > one week. > > That's actually an area of disagreement and confusion. > For some people, next tuesda

Re: Review Request 109841: Use https for web shortcuts

2013-04-22 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109841/ --- (Updated April 22, 2013, 7:10 p.m.) Review request for KDE Runtime. Chan

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Albert Astals Cid
El Dimarts, 23 d'abril de 2013, a les 00:06:27, Sinny Kumari va escriure: > Thank you all for giving useful comments. > > Sorry, I didn't get email which was replied directly to > kde-core-devel@kde.org since I was not subscribed to this list. I checked > all replies from Mailing List archives and

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Albert Astals Cid
El Dilluns, 22 d'abril de 2013, a les 01:22:37, Sinny Kumari va escriure: > Hi all, Hi you, please read the reviews me made. Cheers, Albert > Please review it :) > > Thanks > > On Fri, Apr 12, 2013 at 11:58 PM, Sinny Kumari wrote: > > Hi! > > > > After Plasma Media Center 1.0 release, we f

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread David Edmundson
Summary: Few minor comments. Nothing particularly exciting. All in all I was fairly impressed with the code, it's neat and tidy and you've had 2 releases which is the right approach to getting in Extragear Assuming you've addressed Albert's comments, +1 from me on this. Comments --- FilterPlay

Re: ‘const class KFileItem’ has no member named ‘isFinalIconKnown’

2013-04-22 Thread Frank Reininghaus
2013/4/21 towelday: > I am not able to build kde-baseapps on lfs7.3 > > [ 4%] Building CXX object > dolphin/src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemmodelrolesupdater.o > /sources/blfs/kde-baseapps-4.10.2/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp: > In member function ‘boo

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Sinny Kumari
Hi all, Please review it :) Thanks On Fri, Apr 12, 2013 at 11:58 PM, Sinny Kumari wrote: > Hi! > > After Plasma Media Center 1.0 release, we feel that it should be moved to > Extragear now. It has been moved to kdereview with link > https://projects.kde.org/projects/kdereview/plasma-mediacen

‘const class KFileItem’ has no member named ‘isFinalIconKnown’

2013-04-22 Thread towelday
I am not able to build kde-baseapps on lfs7.3 [ 4%] Building CXX object dolphin/src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemmodelrolesupdater.o /sources/blfs/kde-baseapps-4.10.2/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp: In member function ‘bool KFileItemModelRolesUpdate

Re: Review Request 110110: Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal

2013-04-22 Thread Thomas Lübking
> On April 21, 2013, 11:33 p.m., Àlex Fiestas wrote: > > With this patch we would be creating yet another difference between dolphin > > and the rest of applications using kfileplacesmodel since dolphin uses > > Nepomuk while this patch adds links to folder. > > > > Ideally, nepomuk links shou