Re: Review Request 109792: Update 'dim display' algorithm.

2013-04-15 Thread Danny Baumann
Hi, To expand on the use case I have: I often let my laptop 'do things' (compile code, download stuff, do a 'yum update', wait for an answer of somebody via IM) where immediate attention isn't needed, but it needs to be somewhat monitored nevertheless (does the code still compile or did it abort

Review Request 110027: kjs: Don't crash if code in with-statement causes a "pre"-exception

2013-04-15 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110027/ --- Review request for kdelibs. Description --- For js code like: with({}

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Daniel Nicoletti
2013/4/15 Martin Sandsmark : > On Mon, Apr 15, 2013 at 02:04:43PM +0200, Sebastian Kügler wrote: >> Polling every 5 seconds for a file that is rarely changed is a bug. > > What functionality does it break? I have seem this code before and would ask the same thing, it breaks the kded daemon being ab

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 02:04:43PM +0200, Sebastian Kügler wrote: > Polling every 5 seconds for a file that is rarely changed is a bug. What functionality does it break? I'm not saying it's not suboptimal, and it can be solved in better ways, but I would in no way consider this a bug fix. -- Ma

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Sebastian Kügler
On Monday, April 15, 2013 13:39:34 Martin Sandsmark wrote: > On Mon, Apr 15, 2013 at 01:17:19PM +0200, Martin Gräßlin wrote: > > well not stupidly polling is a bug fix, isn't it? > > That's really trying to twist semantics, IMHO. Polling every five seconds > like it is intended to is not a bug, P

Re: Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 01:17:19PM +0200, Martin Gräßlin wrote: > well not stupidly polling is a bug fix, isn't it? That's really trying to twist semantics, IMHO. Polling every five seconds like it is intended to is not a bug, and now it breaks even worse (by locking out everyone who change their

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Gräßlin
On Monday 15 April 2013 12:43:21 Àlex Fiestas wrote: > This commits only disables the code, if nobody complains I will remove > the full code before 4.11 is out. +1 to remove that code -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Gräßlin
On Monday 15 April 2013 13:10:09 Martin Sandsmark wrote: > On Mon, Apr 15, 2013 at 12:43:21PM +0200, Àlex Fiestas wrote: > > Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. > > Committed on 15/04/2013 at 12:24. > > Pushed by afiestas into branch 'master'. > > I thought kdelibs

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 12:43:21PM +0200, Àlex Fiestas wrote: > Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. > Committed on 15/04/2013 at 12:24. > Pushed by afiestas into branch 'master'. I thought kdelibs master was closed for everything except bug fixes? And why didn't t

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Rolf Eike Beer
Am 15.04.2013 12:43, schrieb Àlex Fiestas: Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. Disable KHostnameD in KDED KHostnameD monitors the hostname by polling gethostname every 5 seconds to adap

[kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Àlex Fiestas
Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. Disable KHostnameD in KDED KHostnameD monitors the hostname by polling gethostname every 5 seconds to adapt some bits of the environment in case the host

Re: Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

2013-04-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109997/ --- (Updated April 15, 2013, 8:48 a.m.) Review request for kdelibs and Frank R

Re: Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

2013-04-15 Thread Frank Reininghaus
> On April 13, 2013, 5 p.m., Christoph Feck wrote: > > Regarding the icon tinting, there are bugs filed against this Dolphin > > behavior, so I am not sure we should replicate it in kdelibs. > > Christoph Feck wrote: > bug 304643, bug 309722 to be more specific :) > > Eike Hein wrote: >

Re: Review Request 109997: Tint selected icon in KFileItemDelegate by highlight color (as Dolphin 2.0)

2013-04-15 Thread Eike Hein
> On April 13, 2013, 5 p.m., Christoph Feck wrote: > > Regarding the icon tinting, there are bugs filed against this Dolphin > > behavior, so I am not sure we should replicate it in kdelibs. > > Christoph Feck wrote: > bug 304643, bug 309722 to be more specific :) In the meantime, the matc