Re: cxx11-cmake-modules in kdereview

> The solution is to have missing services then? IMO, better not have something than to lie about it. It is like that mainly for the systems for which don't really want kde workspaces, but rather just applications (having activities, kwin, etc. under windows or mac is not a desire of ours). A

Re: cxx11-cmake-modules in kdereview

On sexta-feira, 1 de março de 2013 23.11.53, Ivan Čukić wrote: > > Why do you need that? Are you adding source files conditionally, depending > > on whether the compiler supports certain features? > > Yes, as I said, the library builds with any C++ compiler, but the service > requires at least gcc

Re: Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109233/ --- (Updated March 1, 2013, 5:20 p.m.) Review request for kdelibs. Descripti

Re: Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109233/ --- (Updated March 1, 2013, 5:18 p.m.) Review request for kdelibs. Descripti

Review Request 109233: Make nfs isSlow() user configurable in kdeglobals, fixes Bug 290666

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109233/ --- Review request for kdelibs. Description --- NFS (and smb) filesystems

Re: cxx11-cmake-modules in kdereview

> Why do you need that? Are you adding source files conditionally, depending > on whether the compiler supports certain features? Yes, as I said, the library builds with any C++ compiler, but the service requires at least gcc 4.5 equivalent feature set. The service can not use #error since that

Re: cxx11-cmake-modules in kdereview

On sexta-feira, 1 de março de 2013 19.25.40, Ivan Čukić wrote: > One needed feature forgotten, so I'm starting with it: > > Is it possible for cmake scripts to test the Qt defines? Why do you need that? Are you adding source files conditionally, depending on whether the compiler supports certain f

Re: cxx11-cmake-modules in kdereview

One needed feature forgotten, so I'm starting with it: Is it possible for cmake scripts to test the Qt defines? Namely, the kactivities repository is consisted of a few parts that have (as previously agreed) different c++ feature requirements - the library - compilable with any Qt/KDElibs supp

Re: Review Request 109060: [KMenuEdit] Ability to move up/down items

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109060/#review28355 --- kmenuedit/treeview.cpp

Re: cxx11-cmake-modules in kdereview

On sexta-feira, 1 de março de 2013 17.29.26, Martin Gräßlin wrote: > > Why can't you use the #defines from QtCore? > > because we don't use Qt 5 yet? You can simply copy the necessary sections of qcompilerdetection.h into your code if you're still using Qt 4. By construction, your code isn't using

Re: cxx11-cmake-modules in kdereview

On sexta-feira, 1 de março de 2013 18.28.33, Ivan Čukić wrote: > > Can we discuss whether such module should be used? > > Naturally. > > > > Why can't you use the #defines from QtCore? > > From my POV: > - it is not documented - at least, I couldn't find it in Qt 4.8 docs, nor > 5.0 (might be a fa

Re: cxx11-cmake-modules in kdereview

> Can we discuss whether such module should be used? Naturally. > > Why can't you use the #defines from QtCore? >From my POV: - it is not documented - at least, I couldn't find it in Qt 4.8 docs, nor 5.0 (might be a fault of qt-project.org's search mechanism) - it is not extensible - it cover

Re: Re: cxx11-cmake-modules in kdereview

On Friday 01 March 2013 08:12:59 Thiago Macieira wrote: > On sexta-feira, 1 de março de 2013 16.06.38, Ivan Čukić wrote: > > p.s. Please don't start a discussion on whether C++11 should be used or > > not, we have had that already, and everything we are doing is in > > accordance with the decision

Re: cxx11-cmake-modules in kdereview

On sexta-feira, 1 de março de 2013 16.06.38, Ivan Čukić wrote: > p.s. Please don't start a discussion on whether C++11 should be used or > not, we have had that already, and everything we are doing is in > accordance with the decisions made then. Can we discuss whether such module should be used?

Re: Review Request 109196: Add the correct links to PowerDevil KCM modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109196/#review28344 --- This review has been submitted with commit 202239661d6f6a27983

Re: Review Request 109196: Add the correct links to PowerDevil KCM modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109196/#review28343 --- This review has been submitted with commit 6e29938565b3ea1546e

Re: cxx11-cmake-modules in kdereview

Adding Rolf, as he was working on this: http://quickgit.kde.org/?p=scratch%2Fdakon%2Fcmake-cxx11.git On Fri, Mar 1, 2013 at 3:06 PM, Ivan Čukić wrote: > Hi all! > > The CMake modules for detecting C++11 features are going to get in > kdereview > soon. The target for the repository is kdesupport.

cxx11-cmake-modules in kdereview

Hi all! The CMake modules for detecting C++11 features are going to get in kdereview soon. The target for the repository is kdesupport. To clone it, just do the regular: git co kde:cxx11-cmake-modules It would be awesome if our regular CMake experts could give me a few hints on what should be

Re: Review Request 109196: Add the correct links to PowerDevil KCM modules

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109196/#review28319 --- Ship it! Ship It! - Sebastian Kügler On Feb. 28, 2013, 6:14